From a682b9b84a8293da76e8de25ed5ed09072c342cf Mon Sep 17 00:00:00 2001 From: cjihrig Date: Tue, 27 Mar 2018 11:17:33 -0400 Subject: [PATCH 1/2] test: add read_only_space heap space v8.getHeapSpaceStatistics() now includes read_only_space in its results. Update test-v8-stats.js to account for this. Fixes: https://github.com/nodejs/node-v8/issues/44 --- test/parallel/test-v8-stats.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-v8-stats.js b/test/parallel/test-v8-stats.js index 02182e2816b..83689afc974 100644 --- a/test/parallel/test-v8-stats.js +++ b/test/parallel/test-v8-stats.js @@ -25,7 +25,8 @@ const expectedHeapSpaces = [ 'old_space', 'code_space', 'map_space', - 'large_object_space' + 'large_object_space', + 'read_only_space' ]; const heapSpaceStatistics = v8.getHeapSpaceStatistics(); const actualHeapSpaceNames = heapSpaceStatistics.map((s) => s.space_name); From c8e20b68ea7e3180160c20e3ea8d269463e0a80c Mon Sep 17 00:00:00 2001 From: cjihrig Date: Tue, 27 Mar 2018 12:16:51 -0400 Subject: [PATCH 2/2] test: update postmortem metadata test This commit updates the following postmortem metadata constants: - v8dbg_class_SharedFunctionInfo__code__Code - This is now combined with SharedFunctionInfo's function_data. - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object - V8 commit: https://github.com/v8/v8/commit/51ded9d3c0dc430217253595027c6ed207d8cc2d - v8dbg_class_SharedFunctionInfo__raw_name__Object and - v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo - These are now combined as name_or_scope_info. - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object - V8 commit: https://github.com/v8/v8/commit/74a663be675924944a343f2aed71bbe60ef55764 Fixes: https://github.com/nodejs/node-v8/issues/44 --- test/parallel/test-postmortem-metadata.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-postmortem-metadata.js b/test/parallel/test-postmortem-metadata.js index 1f4cc7e6056..b702fa6e993 100644 --- a/test/parallel/test-postmortem-metadata.js +++ b/test/parallel/test-postmortem-metadata.js @@ -93,13 +93,12 @@ function getExpectedSymbols() { 'v8dbg_class_Script__source__Object', 'v8dbg_class_SeqOneByteString__chars__char', 'v8dbg_class_SeqTwoByteString__chars__char', - 'v8dbg_class_SharedFunctionInfo__code__Code', + 'v8dbg_class_SharedFunctionInfo__function_data__Object', 'v8dbg_class_SharedFunctionInfo__compiler_hints__int', 'v8dbg_class_SharedFunctionInfo__end_position__int', 'v8dbg_class_SharedFunctionInfo__function_identifier__Object', 'v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int', - 'v8dbg_class_SharedFunctionInfo__raw_name__Object', - 'v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo', + 'v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object', 'v8dbg_class_SharedFunctionInfo__script__Object', 'v8dbg_class_SharedFunctionInfo__start_position_and_type__int', 'v8dbg_class_SlicedString__offset__SMI',