Skip to content

Add context menu actions to open original/modified file - #589

Closed
Łukasz Rutkowski (Tunous) wants to merge 1 commit into
microsoft:masterfrom
Tunous:change-menu-actions
Closed

Łukasz Rutkowski (Tunous) wants to merge 1 commit into
microsoft:masterfrom
Tunous:change-menu-actions

Conversation

@Tunous

Copy link
Copy Markdown

2018-10-18_17-25-39

Closes #35

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 18, 2018 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Comment thread package.json
},
{
"command": "pr.openOriginalFile",
"when": "false"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the when false do here? The other commands are doing this too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides it from the command palette. That way it can only be run from the context menu where it's added, so it always has the file as an argument

@mledom

Copy link
Copy Markdown

This will be a great addition. Are we just waiting on the PR to be fixed from conflicts?

@RMacfarlane

Copy link
Copy Markdown
Contributor

I just merged Andrew Morgan (@anoadragon453)'s copy of this since it had already pulled in the latest changes. Thanks for making this change, will credit you in the release notes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing context menu actions

5 participants