Skip to content

Add context menu actions to open original/modified file #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Łukasz Rutkowski (Tunous) wants to merge 1 commit into from
Closed

Add context menu actions to open original/modified file #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,16 @@
"title": "Open File in GitHub",
"category": "GitHub Pull Requests"
},
{
"command": "pr.openOriginalFile",
"title": "Open Original File",
"category": "GitHub Pull Requests"
},
{
"command": "pr.openModifiedFile",
"title": "Open Modified File",
"category": "GitHub Pull Requests"
},
{
"command": "pr.openDiffView",
"title": "Open Diff View",
Expand Down Expand Up @@ -191,6 +201,14 @@
"command": "pr.openFileInGitHub",
"when": "false"
},
{
"command": "pr.openOriginalFile",
"when": "false"

@mmanela Matt Manela (mmanela) Oct 19, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the when false do here? The other commands are doing this too.

@RMacfarlane Rachel Macfarlane (RMacfarlane) Oct 19, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides it from the command palette. That way it can only be run from the context menu where it's added, so it always has the file as an argument

},
{
"command": "pr.openModifiedFile",
"when": "false"
},
{
"command": "pr.refreshPullRequest",
"when": "false"
Expand Down Expand Up @@ -260,6 +278,14 @@
{
"command": "pr.openFileInGitHub",
"when": "view =~ /(pr|prStatus)/ && viewItem == filechange"
},
{
"command": "pr.openOriginalFile",
"when": "view =~ /(pr|prStatus)/ && viewItem == filechange"
},
{
"command": "pr.openModifiedFile",
"when": "view =~ /(pr|prStatus)/ && viewItem == filechange"
}
],
"editor/title": [
Expand Down
8 changes: 8 additions & 0 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ export function registerCommands(context: vscode.ExtensionContext, prManager: IP
vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(e.blobUrl));
}));

context.subscriptions.push(vscode.commands.registerCommand('pr.openOriginalFile', (e: GitFileChangeNode) => {
vscode.commands.executeCommand('vscode.open', e.parentFilePath);
}));

context.subscriptions.push(vscode.commands.registerCommand('pr.openModifiedFile', (e: GitFileChangeNode) => {
vscode.commands.executeCommand('vscode.open', e.filePath);
}));

context.subscriptions.push(vscode.commands.registerCommand('pr.openDiffView', (parentFilePath: string, filePath: string, fileName: string, isPartial: boolean, opts: any) => {
if (isPartial) {
vscode.window.showInformationMessage('Your local repository is not up to date so only partial content is being displayed');
Expand Down