Repository navigation
Failure to parse pyproject.toml file when run on Windows #935
Description
Description:
The action is failing with this error message when run on a Windows runner.
Error: Control characters (codes < 0x1f and 0x7f) are not allowed in comments, use \u000d instead at row 19, col 61, pos 454:
18: omit = [
19> "**/tm_devices/commands/**" # TODO: remove this exclusion
^
20: ]
Action version:
I believe that it is v5.2.0
Platform:
- Ubuntu
- macOS
- Windows
Runner type:
- Hosted
- Self-hosted
Tools version:
Repro steps:
Workflow run: https://github.com/tektronix/tm_devices/actions/runs/10624903656/job/29454004640?pr=293
Here is a snippet of the toml file that is failing to be read:
[tool.coverage.report]
exclude_lines = [
"if TYPE_CHECKING:",
"pragma: no cover",
"raise NotImplementedError"
]
fail_under = 100
omit = [
"**/tm_devices/commands/**" # TODO: remove this exclusion
]
show_missing = true
skip_empty = true
[tool.poetry.dependencies]
python = "^3.8" # This is the main Python version requirementExpected behavior:
I expect it to parse the toml file the same way that it works on Ubuntu and MacOS.
Actual behavior:
The file is unable to be parsed due to a false failure for a character that doesn't seem to actually be there.
Activity
v-mahabaleshwars commentedon Aug 30, 2024
Hello @nfelt14,
Thank you for creating this issue. We will investigate it and provide feedback as soon as we have some updates.
FirelightFlagboy commentedon Sep 9, 2024
This issue is fixed by #938 or additional change is required ?
v-priya-kinthali commentedon Sep 9, 2024
Hello👋,
Thank you for bringing this issue to our attention. We have merged PR with the necessary changes into the main branch.
Could you please try using
setup-python@mainand let us know if the issue is resolved? We appreciate your patience and understanding.Use setup-python from main instead of tagged version
Use setup-python from main instead of tagged version
FirelightFlagboy commentedon Sep 9, 2024
Hello @priya-kinthali
I've updated our workflows to use the commit 29a37be in Scille/parsec-cloud@644618d
At least where the update to
5.2.0was failing in the PR Scille/parsec-cloud#8285 the problems where resolve once using the latest commit in mainci: workaround Error: Control characters (codes < 0x1f and 0x7f)
v-priya-kinthali commentedon Sep 18, 2024
Hello @nfelt14 👋,
Just a gentle reminder to check if the issue has been resolved with the
setup-python@main.Could you please confirm? Thanks!
nfelt14 commentedon Sep 18, 2024
Yes, I just confirmed that this works on the main branch.
v-priya-kinthali commentedon Sep 19, 2024
Thankyou for the update!
Bug in actions/setup-python@v5: v5.2.0 does not support pyproject.toml.