Skip to content

Fix dropdown closing after input blur - #162

Open
ScribleSean wants to merge 1 commit into
github:mainfrom
ScribleSean:fix-close-dropdown-on-blur
Open

ScribleSean wants to merge 1 commit into
github:mainfrom
ScribleSean:fix-close-dropdown-on-blur

Conversation

@ScribleSean

Copy link
Copy Markdown

Fixes #136.

Opening results marked the list as being interacted with before a user had touched it. The input blur handler then ignored focus changes and left the dropdown visible after users moved focus away.

Keep the interaction flag false when opening results. The existing list mousedown handler still preserves option selection.

Validation:

  • All 56 Chromium browser tests pass on current main plus this patch, including regular and Popover focus-away, click-away and selection regressions.
  • TypeScript compilation, bundling and custom-elements manifest generation pass.
  • The stock lint/prebuild step currently crashes with escompat/no-optional-chaining: this.findConfigFile is not a function. The same crash occurs when linting unchanged src/debounce.ts; no tooling changes are included here. Lint and build passed on the originally tested September 22 dependency lockfile.

AI assistance: Codex (GPT-6 family; exact preparation variant was not exposed) assisted with investigation, implementation and validation. I reviewed and approved all work before submission and remain responsible for this contribution.

@ScribleSean
ScribleSean requested a review from a team as a code owner October 5, 2026 15:03
Copilot AI balanced review requested due to automatic review settings October 5, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused fix preserves selection handling, includes regression coverage, and has no unresolved findings.

Review effort: Balanced
Findings: None

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown does not close on all blur events

2 participants