Repository navigation
Add guard coverage for gh gist rename - #14745
Merged
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix guard coverage gap for GitHub CLI operation
Add guard coverage for Oct 11, 2026
gh gist rename
lpcox
marked this pull request as ready for review
October 11, 2026 16:12
Collaborator
|
@copilot merge main and resolve conflicts |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The classification, DIFC policy, and tests consistently cover the new operation.
0 open findings
What changed in this PR
Adds guard coverage for the CLI-only gh gist rename mutation.
Changes:
- Classifies
rename_gistas a CLI write. - Applies user-private secrecy and writer integrity labels.
- Adds classification and labeling tests.
| File | Description |
|---|---|
tools.rs |
Registers and tests the CLI write operation. |
tool_rules.rs |
Adds DIFC labels and coverage. |
constants.rs |
Defines and tests the canonical tool name. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…e-fix # Conflicts: # guards/github-guard/rust-guard/src/labels/tool_rules.rs # guards/github-guard/rust-guard/src/tools.rs Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Contributor
Author
Merged |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh gist renamemutates a gist throughPOST /gists/{gist_id}but lacked a guard write classification and DIFC rule.rename_gistto the CLI-only write inventory.