Repository navigation
Add strongly typed Permissions struct for GitHub Actions permissions - #1980
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Collaborator
|
@copilot add extensive tests for merge |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add strongly typed Permissions struct for GitHub actions
Add strongly typed Permissions struct for GitHub Actions permissions
Oct 19, 2025
pelikhan
approved these changes
Oct 19, 2025
pelikhan
marked this pull request as ready for review
October 19, 2025 17:12
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Added 36 extensive test cases for the Merge method covering:
All tests validate proper precedence rules (write > read > none) and shorthand conversion behavior. Commit: TBD
Added 36 extensive test cases for the Merge method covering:
All tests validate proper precedence rules (write > read > none) and shorthand conversion behavior. Commit: f31d353 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add Strongly Typed Permissions Struct
Permissionsstruct inpkg/workflow/permissions.gowith:Test Coverage for Merge Method
Added 36 comprehensive test cases covering:
Map-to-Map Merges (8 tests)
Shorthand-to-Shorthand Merges (15 tests)
Shorthand-to-Map Merges (5 tests)
Map-to-Shorthand Merges (4 tests)
Edge Cases (4 tests)
All 36 tests pass successfully ✅
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.