Repository navigation
Method snippet follow-up #46568
Description
List of follow-up items from #46370 that were easier to put in separate PR(s). I tried to sort these by priority order, and the last couple I don’t think we’ll schedule at all for now. We can close this issue when we’ve done everything worth scheduling for a milestone.
-
Add$0tabstop at the same location as$1tabstop (in method body) -
Make auto-imported types work
- Moderate effort
- Sending this back as part of
getCompletionsAtPositionwould require a protocol change and corresponding update in typescript-language-features. There are some workarounds we could implement by sending the back as part ofgetCompletionEntryDetailsinstead, which would work with no VS Code update. Maybe we should discuss this at next week's editor sync. My feeling is this qualifies as a bug fix, but if we need a VS Code update, we’ll need to coordinate with Matt Bierner (@mjbvz), and we’re also nearing the end of our own release cycle, so I’m not sure what the best strategy is here.
-
From Andrew Casey (@amcasey) at Add method signature completions #46370 (comment):
publicmust precedeabstract.- Maybe 4.6?
-
From Andrew Casey (@amcasey) at Add method signature completions #46370 (comment):
if you name the method to be overridden "abstract", "async", etc, the completion clobbers the keyword completion. It did this before the change too, but then it would insert the same text either way - now it inserts a whole function declaration.
- This can be backlog / help wanted / when you have time for it.
-
Improve
addMissingMembercodefix’s generated implementation signature for overloads (currently all parameters areunknown(as of feat(47281): Implementing an interface suggests any as type #47308))- Let's listen for feedback about this. Unless you feel strongly about it or we hear a lot of complaints, I think this can be backlog / help wanted.
Activity
andrewbranch commentedon Oct 29, 2021
Two more things:
replacementSpanAdd method signature completions #46370 (comment)namein the completion list; I think a display ofmethod(p1: string, p2: number, ...(probably the whole first line of theinsertText, maybe truncated at some number of characters?) would be better, but we can discuss this at an upcoming editor sync.gabritto commentedon Oct 29, 2021
I have found I don't miss this when I have completions preview turned on. Also, at least in VSCode there is a truncated preview of the insert text next to the name of the completion, but I don't know how other editors display this.
andrewbranch commentedon Oct 29, 2021
100%. I think this is why I didn't notice this in my initial review of #46370. But it's still not the default.
This is actually the detail text that we’ve always generated in completion details. It does help, but the fact that it's the same as it's always been for completions that just insert the name (and the same as it will continue to be if a user disables the member completion snippets) makes me feel like maybe it should be more obvious that we're going to insert additional text... but this is definitely worth gathering feedback on; I don't feel like I have the perfect answer.