Repository navigation
perf: optimize main class picker ordering - #1712
Closed
Deleted user (ghost) wants to merge 2 commits into
Closed
Deleted user (ghost) wants to merge 2 commits into
Deleted user (ghost) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Avoid mutating caller-owned arrays and cache the active editor path while reordering recent quick-pick items. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ghost
requested review from
Changyong Gong (chagong),
Sheng Chen (jdneo),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
October 11, 2026 03:28
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change reduces unnecessary work in the main class picker by avoiding mutation of caller-owned arrays and by caching the active editor path while reordering recent quick-pick entries.
Why
The picker can get large result sets, and the current code was repeatedly calculating the active file path for each option while also sorting the original array in place. This creates extra work for every launch flow and can make the quick pick noticeably slower when there are many Java main classes.
Changes
Validation
npm run compile