Skip to content

Improve outdated comments experience #5760

Description

@alexr00

Discussing with Henning Dieterichs (@hediet) and we found some things that could significantly improve outdated comments:

  • Add some indicator in the comment widget that the comment is outdated
  • When clicking on the comment, don't just open the outdated file with the comment, instead open the a diff with the outdated file on the left and the head on the right.

Activity

  1. alexr00 commented on Mar 5, 2024

    @alexr00
    MemberAuthor

    Example of what we have now:

    Image

  2. added a commit that references this issue on Mar 8, 2024
    453104f
  3. alexr00 commented on Mar 8, 2024

    @alexr00
    MemberAuthor

    I don't see a nice way to enable clicking on the comment thread to open a diff. Currently, clicking on the comment thread opens the resource that the comment applies to. I don't want to open this up to arbitrary commands.

    I've added an inline action to diff the comment with the head. I'm hoping that this will also function as an indicator that it's an outdated comment.

  4. added a commit that references this issue on Mar 8, 2024
    ea0930d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions