Plan for November 2018 #678
Description
Activity
This is super exciting!
suggested changes/suggest comments
This is a feature similar to what we've been internally using through Nuclide Phabricator integration and we allow users to accept as many suggested changes as they would like and create one commit out of them, looks like it was one of the biggest asks by the community from the Github team during their public beta. Is there a proposed vscode core API that would enable extensions to power suggested changes in the editor? As a reviewer would I be able to edit code and use the diff as suggested changes to be pushed to the code author?
resolve a conversation
On Github resolving a comment is a sub action of hiding a comment, is this going to hook into that behavior?
In Nuclide we have a notion of resolving comments and it hooks up to Phabricator and is a way for a reviewer to see their comment has been addressed and as the code author for one to keep track of what comments have been addressed and what is pending. It also allows for a filter that can be used to show/hide resolved comments. With that use case would the concept of resolving a comment be specific to the pull request package or is this going to be leveraging vscode core API that allows marking a comment as resolved?
Reacted by Jerry GreenOn Github resolving a comment is a sub action of hiding a comment, is this going to hook into that behavior?
Yes, this can be done from the extension side. We can send a comment update to the core and ask the core to either remove the comment or set the collapsible state of the comment to
false.it hooks up to Phabricator and is a way for a reviewer to see their comment has been addressed and as the code author for one to keep track of what comments have been addressed and what is pending
We'll probably introduce Flag/Type property for comments or comment threads in the core API. With the flag, we can
- Sort/Filter comments in Comment Panel.
- Display the state in both Comment Panel and Comment Widget.
- We can change the type of a comment/comment thread in Comment directly. Once the type of the comment is changed, we can update the visibility/collapsible state as well.
IMO it would be better than having the
Resolve Conversationin the core API.Reacted by Aaditya SriramIntelliSense for @mentions and issue numbers
The same api can work for assigning reviewers and assignees, right now after I created a PR, I have to come back the website for that.
Reacted by bhackAuthentication issue we are running into now microsoft/vscode#60773 .
- changed the title
[-]Plan for November 2018 [DRAFT] [/-][+]Plan for November 2018[/+]on Dec 13, 2018
Plan Items
Pain points / Missing functionality