Skip to content

Issue links in overview HTML are emitted with an extra quote in href #9022

Agent suggestions

Public preview

Description

@strawberry-little-bear
  • Extension version: 0.166.1 (current main package.json)
  • VSCode Version: not applicable to the source-level reproduction; the extension declares ^1.141.0
  • OS: Windows 11 (source-level reproduction; the generated HTML is platform-independent)
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): GitHub.com

Steps to Reproduce:

  1. Open a pull request or issue whose description contains a link to another issue in the same repository, for example https://github.com/microsoft/vscode-pull-request-github/issues/123.
  2. Let the extension convert the description HTML for the issue/PR overview.
  3. Inspect the generated anchor for the issue link.

The issue-link branch in src/github/utils.ts currently returns:

return `href="${(await toOpenIssueWebviewUri(...)).toString()}""`;

That produces an anchor like:

<a href="vscode://github.vscode-pull-request-github/open-issue-webview?..."">#123</a>

The corresponding pull-request branch returns a normally terminated href, so this only affects links converted from /issues/<number> URLs.

The extra quote is parsed as a second, nameless attribute (rather than being part of the href value). The link may still appear to work in some Chromium versions, but the HTML is malformed and can be handled inconsistently by the webview DOM/sanitizer. It also makes the generated markup different from the PR-link path for no functional reason.

The smallest fix appears to be removing the extra " at the end of the issue branch, and adding a regression test around the HTML returned for a same-repository issue link. I have not changed the repository code yet; this report is based on the current main source and a local HTML parsing reproduction.

Activity

  1. added
    bugIssue identified by VS Code Team member as probable bug
    on Oct 8, 2026
  2. added this to the 1.142.0 milestone on Oct 8, 2026
  3. marked Gyh #9053 as a duplicate of this issue on Oct 11, 2026
  4. unmarked Gyh #9053 as a duplicate of this issue on Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions