You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normalize enum separators in user-facing reason labels
webviews/components/comment.tsx:91
GraphQL returns enum values such as OFF_TOPIC; lowercasing alone renders the user-facing reason as off_topic. Normalize enum separators (or map the enum to display labels) so all supported reasons are readable.
minimizedReason can contain classifier values such as OFF_TOPIC (as represented by the new parser test), so lowercasing alone renders the user-facing reason as off_topic. Normalize underscores to hyphens so the message matches GitHub's “off-topic” wording.
🧠 Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #7431
Summary
isMinimized,minimizedReason) to gql query and used in the component to minimize with the reason open the comment on click.Demo:
Hidden.comments.mp4
Follow ups