Skip to content

Escape test ID`s in Testing API #17810

Closed as not planned
Closed as not planned
Escape test ID`s in Testing API#17810
Labels
area-testingbugIssue identified by VS Code Team member as probable bugneeds PRReady to be worked on

Description

@perseus-fyi
Ruslan Nasonov (perseus-fyi)
opened on Oct 20, 2021

I have Python project with pytest's tests and I catch this error

Error: Test IDs may not include the "<path-to-test>/tests/unit/interactions/mastercard/test_mastercard.py::TestMasterCardDeleteCard::test_generic_404_exception_is_not_affected[\u0000]" symbol
	at new D (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
	at Object.createTestItem (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:95)
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at Array.forEach (<anonymous>)
	at g (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at m (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at Object.forEach (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
	at g (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at m (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at Object.forEach (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
	at g (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at m (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at Object.forEach (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
	at g (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at m (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at Object.forEach (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
	at g (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at m (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9
	at Object.forEach (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:87)
	at g (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at Object.m [as updateTestItemFromRawData] (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:9)
	at _.resolveChildren (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:59)
	at _.refreshTestData (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:59)
	at processTicksAndRejections (internal/process/task_queues.js:93)
	at async v.refreshTestDataInternal (vscode-file://vscode-app/Users/perseus/.vscode/extensions/ms-python.python-2021.10.1336267007/out/client/extension.js:59)

Pytest allow to parametrize and test looks like this

    @pytest.mark.asyncio
    @pytest.mark.parametrize('body', ['', 'test', '{}', '{"test": true}', b'', b'\x00'])
    async def test_generic_404_exception_is_not_affected(

-> test_generic_404_exception_is_not_affected[\u0000] is valid test name

Screenshot 2021-10-20 at 11 48 18

Version: 1.61.2

Activity

  1. VS Code Issue Triage Bot (vscode-triage-bot)
    assigned
    Connor Peet (connor4312)
    on Oct 20, 2021
  2. Connor Peet (connor4312)
    assigned
    Karthik Nadig (karthiknadig)
    and unassigned
    Connor Peet (connor4312)
    on Oct 20, 2021

  3. connor4312 commented on Oct 20, 2021

    @connor4312
    Connor Peet (connor4312)
    on Oct 20, 2021
    Member

    NUL bytes are not allowed in test IDs, since we use it for delimiters internally

  4. perseus-fyi commented on Oct 20, 2021

    @perseus-fyi
    Ruslan Nasonov (perseus-fyi)
    on Oct 20, 2021
    Author

    I found workaround using ids parameter

    @pytest.mark.parametrize('body', ['', 'test', '{}', '{"test": true}', b'', b'\x00'], ids=str)

    But this restrictions looks strange ...

  5. Karthik Nadig (karthiknadig)
    transferred this issue frommicrosoft/vscodeon Oct 20, 2021
  6. Karthik Nadig (karthiknadig)
    removed their assignment
    on Oct 20, 2021
  7. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Oct 20, 2021
  8. Karthik Nadig (karthiknadig)
    self-assigned this
    on Oct 20, 2021
  9. Karthik Nadig (karthiknadig)
    added
    area-testing
    triage
    bugIssue identified by VS Code Team member as probable bug
    and removed
    triage-neededNeeds assignment to the proper sub-team
    on Oct 20, 2021

  10. karthiknadig commented on Oct 20, 2021

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Oct 20, 2021
    Member

    We have plans on rewriting the test adapter. We should handle this case there.

    /cc Kim-Adeline Miguel (@kimadeline)

  11. kimadeline commented on Oct 20, 2021

    @kimadeline
    Kim-Adeline Miguel (kimadeline)
    on Oct 20, 2021

    #17242

  12. Karthik Nadig (karthiknadig)
    added
    needs PR
    and removed
    triage
    on Oct 25, 2021
  13. Karthik Nadig (karthiknadig)
    removed their assignment
    on Oct 25, 2021
  14. github-actions
    removed
    needs PR
    on Aug 9, 2022
  15. Kartik Raj (karrtikr)
    added
    needs PRReady to be worked on
    on Aug 9, 2022

  16. karrtikr commented on Dec 22, 2022

    @karrtikr
    Kartik Raj (karrtikr)
    on Dec 22, 2022

    Closing in favor of #17242.

  17. Kartik Raj (karrtikr)
    closed this as not plannedon Dec 22, 2022
  18. github-actions
    locked as resolved and limited conversation to collaborators on Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-testingbugIssue identified by VS Code Team member as probable bugneeds PRReady to be worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions