Skip to content

Work around VSC issue with formatting on save #624

Closed
#635
Closed
Work around VSC issue with formatting on save#624
#635
Assignees
MikhailArkhipov
Labels
area-formatting
Milestone
January 2018

Description

@MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)
opened on Jan 24, 2018

microsoft/vscode#41194

Plan:

  • Save buffer content on formatting
  • if edits were created, remember that we've formatted
  • upon 'file saved' event check if edits were actually applied
  • if not, then execute 'format document' command and save the file
  • document workaround in release notes
  • remove it when upstream issue is saved.

Addresses
#590
#124
#492

Activity

  1. Mikhail Arkhipov (MikhailArkhipov)
    self-assigned this
    on Jan 24, 2018
  2. Mikhail Arkhipov (MikhailArkhipov)
    added this to the January 2018 milestone on Jan 24, 2018
  3. Don Jayamanne (DonJayamanne)
    added
    area-formatting
    upstream-vscode
    on Jan 26, 2018
  4. Mikhail Arkhipov (MikhailArkhipov)
    closed this as completedin #635on Jan 29, 2018
  5. Mikhail Arkhipov (MikhailArkhipov)
    added a commit that references this issue on Jan 29, 2018

    Work around VSC issue with formatting on save #624 (#635)

    94cd778
  6. Brett Cannon (brettcannon)
    added
    awaiting 4-validation
    closed-fixed
    on Jan 29, 2018

  7. MikhailArkhipov commented on Jan 29, 2018

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Jan 29, 2018
    Author

    94cd778

  8. Mikhail Arkhipov (MikhailArkhipov)
    reopened this on Jan 29, 2018

  9. MikhailArkhipov commented on Jan 29, 2018

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Jan 29, 2018
    Author

    94cd778

  10. Mikhail Arkhipov (MikhailArkhipov)
    closed this as completedon Jan 29, 2018
  11. Brett Cannon (brettcannon)
    removed
    awaiting 4-validation
    on Jan 30, 2018
  12. Mikhail Arkhipov (MikhailArkhipov)
    added a commit that references this issue on Feb 1, 2018

    Formatting on Enter (#649)

    b45aae3
  13. Brett Cannon (brettcannon)
    added
    closed-verified fixed
    and removed
    closed-fixed
    on Feb 1, 2018
  14. lock
    locked as resolved and limited conversation to collaborators on Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-formatting

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions