Repository navigation
Support migrating storage for extensions adopting pre-release #140088
Description
Activity
Joyce Er (@joyceerhl) added following embedder API to support extension storage migration
type MarketplaceExtension = ExtensionId | { readonly id: ExtensionId, preRelease?: boolean, migrateStorageFrom?: ExtensionId };
This will be available from tomorrow's insiders
- added a commit that references this issue
on Jan 11, 2022 Tested
migrateStorageFromAPI in Code-OSS + vscode.dev + RemoteHub, migration works like a charm and uncommitted changes in RemoteHub workspaces are preserved. Here's what I did to verify that the API works as expected:- Reset VS Code web storage (since storage migration is only done once and skipped thereafter)
- Start Code-OSS web out of sources
- Start vscode.dev out of sources bundling GitHub.remotehub-insiders
- Make a change to a file in the microsoft/vscode repo using GitHub.remotehub-insiders
- Apply change to vscode.dev to bundle prerelease GitHub.remotehub and
migrateStorageFromGitHub.remotehub-insiders - Reload vscode.dev
- Verify that the change made in step 4 is still there
- Verify that pre-release of GitHub.remotehub is installed, not GitHub.remotehub-insiders
Will repeat this tomorrow with the VS Code Insiders build, but so far looking good. Thanks for the quick turnaround on this!
Reacted by Sandeep SomavarapuAPI is looking good in Insiders with the following steps:
- Start vscode.dev out of sources bundling GitHub.remotehub-insiders
- Access vscode.dev/github/microsoft/vscode?vscode-quality=insiders
- Make a change to a file (and repeat steps 2 and 3 with a couple more repos for completeness)
- Apply change to vscode.dev to bundle prerelease GitHub.remotehub and
migrateStorageFromGitHub.remotehub-insiders - Reload vscode.dev
- Verify that the change made in step 3 is still there and that all other changes are accessible from Remote Explorer
- Verify that pre-release of GitHub.remotehub is installed, not GitHub.remotehub-insiders
- added a commit that references this issue
on Jan 12, 2022 - added a commit that references this issue
on Jan 12, 2022 Joyce Er (@joyceerhl) Can you please verify this or mark this verified as you adopted this?
Marked as verified since I have adopted this in vscode.dev as of two weeks ago.
- locked and limited conversation to collaborators
on Feb 26, 2022
Support migrating storage for extensions adopting pre-release
Migration includes following: