Repository navigation
October 2022 Endgame #164400
Description
Activity
- pinned this issue
on Oct 23, 2022 - assigned and unassigned
on Oct 24, 2022 Peng Lyu (@rebornix) I've been noticing a bit of confusion regarding the "version" property in
https://github.com/microsoft/vscode/blob/main/package.jsonduring the phase before releasing a new version. So, for example during Monday-Wednesday before the planned release 1.73 this week Wednesday, we see "version": "1.73.0" for the main branch, but in fact it should be "1.74.0", since the main branch has already been worked on with commits belonging to 1.74 (November release)Wouldn't it be more logical to switch the main branch version to 1.74 immediately after the release/1.73 branch was created (Friday last week, AFAICT) and just before work begins on 1.74?
If this change were done, you wouldn't need the
Bump up the version in package.json on mainentry anymore for Wednesday/Thursday.Lorand Horvath (@lorand-horvath) thanks for the reminder and it makes good sense to bump version in the main branch right after we create the release branch.
Reacted by Lorand HorvathPeng Lyu (@rebornix) Looks like it didn't work as expected: 447e61a
It should've worked. It will work from now on: #165132
Reacted by Lorand Horvath- unpinned this issue
on Nov 3, 2022 - locked and limited conversation to collaborators
on Dec 18, 2022
Monday
verification-neededoron-testplanlabelTuesday
Wednesday
Thursday
Friday
stablebuild to ensure stable build is green Peng Lyu (@rebornix)insiderbuilds Peng Lyu (@rebornix)release/<x.y>after all expected fixes are in (latest 5PM PST) Peng Lyu (@rebornix)release/<x.y>after all expected fixes are in (latest 5PM PST) Peng Lyu (@rebornix)release/<x.y>after all expected fixes are in (latest 5PM PST) ownerrelease/*as the VS Code Branch parameter (it's the default so you shouldn't have to change anything) Peng Lyu (@rebornix)mainis open for business Peng Lyu (@rebornix)candidate)v<Major>_<Minor>.mdin this repo directorydebug-adapter-protocol,inno-updater,jsonc-parser,language-server-protocol,lsif-node,vscode,vscode-codicons,vscode-css-languageservice,vscode-debugadapter-node,vscode-dev-containers,vscode-docs,vscode-emmet-helper,vscode-eslint,vscode-extension-samples,vscode-generator-code,vscode-hexeditor,vscode-html-languageservice,vscode-js-debug,vscode-js-debug-companion,vscode-js-profile-visualizer,vscode-jshint,vscode-json-languageservice,vscode-languageserver-node,vscode-livepreview,vscode-loader,vscode-lsif-extension,vscode-node-debug,vscode-node-debug2,vscode-pull-request-github,vscode-recipes,vscode-references-view,vscode-textmate,vscode-vsceFriday/Monday
Monday - Wednesday
release/<x.y>Peng Lyu (@rebornix)Insiderfromrelease/<x.y>Peng Lyu (@rebornix)InsiderPeng Lyu (@rebornix)scripts/test-documentation.sh|batand add file or fix issues if there are new colors that are not documented. Peng Lyu (@rebornix)Wednesday/Thursday - Expected release day (this may change)
sudo snap install --classic --dangerous <file>.snap) ownerproddeployment target. Request approval from another team member at the necessary step. Peng Lyu (@rebornix)git tag <x.y.z>git push origin <x.y.z>... > Create Release. Use the correct title and description from our release notes. Also change the relative links for the key highlight list items to absolute links Exampleinsiderbuilds Peng Lyu (@rebornix)package.jsononmain- Peng Lyu (@rebornix)