Skip to content

Move run in terminal tool to core - #255804

Merged
Daniel Imms (Tyriar) merged 32 commits into
mainfrom
tyriar/252650
Jul 16, 2025
Merged

Daniel Imms (Tyriar) merged 32 commits into
mainfrom
tyriar/252650

Conversation

@Tyriar

@Tyriar Daniel Imms (Tyriar) commented Jul 14, 2025 •

Copy link
Copy Markdown
Contributor

This PR moves the entirely of both the runInTerminal and getTerminalOutput tools (which depends on runInTerminal) into the core codebase. This was mostly a simple but tedious task, but the invoke calls in particular needed a decent amount of changes to move to the lower-level and richer APIs provided internally like ICommandDetectionCapability.

The goal was to do a straight conversion to reduce the risk of things going wrong, not to improve upon what we had yet. As such, the following debt tasks I'm tackling after this gets merged and we migrate successfully:

Part of #252650


TODO

@Tyriar Daniel Imms (Tyriar) added this to the July 2025 milestone Jul 14, 2025
@Tyriar Daniel Imms (Tyriar) self-assigned this Jul 14, 2025
@Tyriar
Daniel Imms (Tyriar) marked this pull request as ready for review July 16, 2025 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants