Repository navigation
Move run in terminal tool to core - #255804
Merged
Merged
Conversation
This was referenced Jul 16, 2025
Daniel Imms (Tyriar)
marked this pull request as ready for review
July 16, 2025 13:26
Daniel Imms (Tyriar)
enabled auto-merge
July 16, 2025 13:33
Megan Rogge (meganrogge)
approved these changes
Jul 16, 2025
This was referenced Jul 23, 2025
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the entirely of both the
runInTerminalandgetTerminalOutputtools (which depends onrunInTerminal) into the core codebase. This was mostly a simple but tedious task, but the invoke calls in particular needed a decent amount of changes to move to the lower-level and richer APIs provided internally likeICommandDetectionCapability.The goal was to do a straight conversion to reduce the risk of things going wrong, not to improve upon what we had yet. As such, the following debt tasks I'm tackling after this gets merged and we migrate successfully:
Part of #252650
TODO
getCopilotTerminalsin the extension fine?runInTerminal->runInTerminal2