Repository navigation
ci: give every Windows CI job the 70 minute timeout - #340816
Michael Lively (Yoyokrazy) wants to merge 1 commit into
Conversation
#340808 raised only Unit Tests to 70 minutes. Browser & Remote and Integration (Electron) also time out at 50 minutes after a node_modules cache miss: since Sep 30, 3 and 1 of 35 cold Windows builds timed out, and another 7 and 6 finished within 3 minutes of the limit. Refs: microsoft/vscode-engineering#2896 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused pipeline and test changes correctly implement the stated timeout policy without affecting other platforms or product-build jobs.
0 open findings
What changed in this PR
Extends all Windows x64 CI test jobs to a 70-minute timeout for cold dependency installs.
Changes:
- Replaces conditional 50/70-minute limits with an unconditional 70-minute limit.
- Updates the regression test while preserving the 10-minute cancellation timeout.
| File | Description |
|---|---|
build/azure-pipelines/win32/product-build-win32-ci.yml |
Sets every Windows CI test job to 70 minutes. |
build/lib/test/testCheckpointTemplates.test.ts |
Verifies the unconditional timeout and cancellation limit. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
cc Bryan Chen (@bryanchen-d): follow-up to #340808. Browser & Remote and Integration (Electron) still time out at 50 minutes on cold-cache builds: 3 and 1 timeouts since Sep 30 (481525, 481690, 482239; 481097), and 482906 today hit 47.3m on Browser & Remote. This gives every Windows CI job 70 minutes. Auto-merge is on. |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Refs microsoft/vscode-engineering#2896. Follow-up to #340808.
#340808 raised Windows Unit Tests to 70 minutes. Browser & Remote and Integration (Electron) also time out at 50 minutes when the
node_modulescache misses, because the clean install takes about 14–16 minutes on Windows. This PR gives every Windows CI job 70 minutes. The timeout is only an upper bound, so runs with a warm cache don't get slower.Main CI, Sep 30–Oct 9 (247 builds, 35 with a cold Windows cache):
Every timeout was on a cold cache. With a warm cache, no Windows job went above 36.2m.
How to test
node --test build/lib/test/testCheckpointTemplates.test.ts build/lib/test/testCheckpoint.test.tseslint build/lib/test/testCheckpointTemplates.test.ts