Repository navigation
fix #5888 - #6035
Merged
Johannes Rieken (jrieken) merged 1 commit intoMay 2, 2016
Merged
fix #5888#6035Johannes Rieken (jrieken) merged 1 commit into
Johannes Rieken (jrieken) merged 1 commit into
Conversation
|
By analyzing the blame information on this pull request, we identified Johannes Rieken (@jrieken) and alexandrudima to be potential reviewers |
|
Hi Yuki Ueda (@Ikuyadeu), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| const model = this.editor.getModel(); | ||
| const supports = SuggestRegistry.all(model); | ||
| this.shouldShowEmptySuggestionList = supports.some(s => s.shouldShowEmptySuggestionList()); | ||
| this.shouldShowEmptySuggestionList = supports.some(s => true); |
Contributor
There was a problem hiding this comment.
just set it to true, not need for some
Contributor
|
this will fix #5888 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removeｄ ISuggestSupport#shouldShowEmptySuggestionList(): boolean;