Repository navigation
setup default valid hosts for graph in graph core #1139
Description
related to microsoft/kiota#1063
related to microsoft/kiota-typescript#505
The original value for the default valid hostnames was removed from kiota authentication libraries to make them API agnostic and easier to use with other APIs.
Since the initialization of the client is a bit different here compared with other languages, I'm opening this issue to discuss the best approach to set those default values in graph core.
In other languages the approach was to make derived authentication and access token providers that would set the default.
Original default values:
new Set<string>([
"graph.microsoft.com",
"graph.microsoft.us",
"dod-graph.microsoft.us",
"graph.microsoft.de",
"microsoftgraph.chinacloudapi.cn",
"canary.graph.microsoft.com",
]
Activity
nikithauc commentedon Jan 17, 2023
We already have this
msgraph-sdk-javascript/src/Constants.ts
Line 28 in 597acce
nikithauc commentedon Jan 17, 2023
Currently this constant set is used to append or remove an auth header and telemetry header.
baywet commentedon Jan 18, 2023
Thanks for the information.
How do you suggest we inject that value in the authentication providers (spfx, az identity,...) ? derive and overload or some other approach?
nikithauc commentedon Jan 18, 2023
msgraph-sdk-javascript/src/GraphRequestUtil.ts
Line 132 in 65310a8
Passing it at the time of initialization client instance.
baywet commentedon Jan 18, 2023
oh so it's already being done? perfect then. If you could just confirm and close the issue please.