Race condition between socket timeout and new client requests #23

Activity

1. pmalouin commented on Apr 23, 2015

   

   pmalouin

   on Apr 23, 2015

   ContributorAuthor

   More actions

   I was able to reproduce the problem with this small script:

   var Agent = require('agentkeepalive');
   var http = require('http');
   
   var _keepaliveAgent = new Agent({
       maxSockets: 1,
       maxFreeSockets: 1,
       keepAliveTimeout: 1000
   });
   
   var options = {
       hostname: 'www.google.com',
       port: 80,
       path: '/',
       method: 'GET',
       agent : _keepaliveAgent
   };
   
   var getRequest = function() {
       var req =  http.request(options, function(res) {
           res.on('data', function(chunk) {
               console.log('BODY: ' + chunk);
           });
           res.on('end', function() {
               console.log('END REQ');
           });
       });
       req.on('error', function(e) {
           console.log('problem with request: ', e);
       });
       return req;
   };
   
   var req = getRequest();
   // Get a reference to the socket.
   req.on('socket', function(sock) {
       // Listen to timeout and send another request immediately.
       sock.on('timeout', function() {
           getRequest().end();
       });
   });
   req.end();
   
   setTimeout(function() {
       // Just keep the process hanging because listening to 'timeout' is not enough to keep the process spinning.
   }, 2500);

   The first http request succeeds, the second fails with ECONNRESET.
2. fengmk2 commented on Apr 25, 2015

   

   fengmk2

   on Apr 25, 2015

   Member

   More actions

   e6a83a5
3. fengmk2

   closed this as completedon Apr 25, 2015
4. fengmk2

   added

   bug

   on Apr 25, 2015
5. pmalouin commented on Apr 27, 2015

   

   pmalouin

   on Apr 27, 2015

   ContributorAuthor

   More actions

   Thanks, I updated and it's all good for me!