Skip to content

Upcoming metadata changes in V8 6.7 #180

Closed

Description

@cjihrig

The following changes are coming:

  • v8dbg_class_SharedFunctionInfo__code__Code

    • This is now combined with SharedFunctionInfo's function_data.
    • Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
    • V8 commit: v8/v8@51ded9d
  • v8dbg_class_SharedFunctionInfo__raw_name__Object and

  • v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo

    • These are now combined as name_or_scope_info.
    • Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
    • V8 commit: v8/v8@74a663b

Refs: nodejs/node-v8#47

Activity

  1. mmarchini commented on May 3, 2018

    @mmarchini
    Contributor

    I plan to start working on this next week, so we'll be prepared when V8 6.7 land on v10.0.0.

    I don't think v8dbg_class_SharedFunctionInfo__function_data__Object will impact llnode. I couldn't find any call to SharedFunctionInfo::GetCode... v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object will be fun though 😅

  2. cjihrig commented on May 3, 2018

    @cjihrig
    ContributorAuthor

    I don't think v8dbg_class_SharedFunctionInfo__function_data__Object will impact llnode. I couldn't find any call to SharedFunctionInfo::GetCode...

    When I originally created the postmortem metadata test, I added the constants from llnode and mdb_v8, so it could be an mdb_v8 thing.

  3. added a commit that references this issue on May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions