Skip to content

AIX, FreeBSD: test-cluster-disconnect-handles intermittent failures #10609

Closed
Closed
AIX, FreeBSD: test-cluster-disconnect-handles intermittent failures#10609
Labels
aixIssues and PRs related to the AIX platform.clusterIssues and PRs related to the cluster subsystem.freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@mhdawson
mhdawson
opened on Jan 4, 2017
  • Version: master
  • Platform: AIX
  • Subsystem: cluster

I've seen a number of failures on this test over the last little while:

https://ci.nodejs.org/job/node-test-commit-aix/2942/nodes=aix61-ppc64/console

not ok 127 parallel/test-cluster-disconnect-handles
  ---
  duration_ms: 60.107
  severity: fail
  stack: |-
    timeout
  ...

Activity

  1. mscdex
    added
    aixIssues and PRs related to the AIX platform.
    clusterIssues and PRs related to the cluster subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Jan 4, 2017

  2. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    Also FreeBSD.

    https://ci.nodejs.org/job/node-test-commit-freebsd/6249/nodes=freebsd10-64/console

    not ok 226 parallel/test-cluster-disconnect-handles
  ---
  duration_ms: 60.78
  severity: fail
  stack: |-
    timeout

  3. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    Seems like this comment in the test kinda sorta acknowledges that there is a race condition:

              // It can happen that the first continue was sent before the break
          // event was received. If that's the case, send also a continue from
          // here so the worker exits

  4. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    The test uses --debug so it's going to break when we update V8 at some point in the next few months.

    Not sure if the right thing to do is just get rid of the test or to rewrite it to use something else like --inspect.

    /cc @nodejs/testing @nodejs/diagnostics @jkrems @s3ththompson @eugeneo

  5. Trott
    added
    freebsdIssues and PRs related to the FreeBSD platform.
    debugger
    on Jan 4, 2017
  6. Trott
    changed the title [-]AIX: test-cluster-disconnect-handles intermittent failures[/-] [+]AIX, FreeBSD: test-cluster-disconnect-handles intermittent failures[/+] on Jan 4, 2017

  7. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    Hopefully I didn't typo any of the things in the form, but stress tests for...

    AIX: https://ci.nodejs.org/job/node-stress-single-test/1097/nodes=aix61-ppc64/console

    FreeBSD: https://ci.nodejs.org/job/node-stress-single-test/1098/nodes=freebsd10-64/console

  8. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    Oh, maybe the failure could be due to a stuck debugger test on one of the hosts preventing usage of the TCP port. I know @thefourtheye has been trying to get the debugger tests working again, and that's involved running them in CI for the first time in a very long time. And some of them hung...

  9. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    /cc @bnoordhuis who wrote the test in the first place, especially on the question of whether it makes sense to port the test to something that doesn't use the to-be-removed debug protocol or whether it makes sense to simply delete the test. (Basically: Is the debug protocol part of what's actually being tested? Doesn't seem like it to me, but ¯\(ツ)/¯ )

  10. Trott commented on Jan 4, 2017

    @Trott
    Trott
    on Jan 4, 2017
    Member

    PR where the test landed: #3677

    Maybe /cc @indutny on how to proceed as well...

  11. mhdawson commented on Jan 31, 2017

    @mhdawson
    mhdawson
    on Jan 31, 2017
    MemberAuthor

    Another failure here: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/3511/console

  12. mhdawson commented on Jan 31, 2017

    @mhdawson
    mhdawson
    on Jan 31, 2017
    MemberAuthor

    I think this may also require cleanup after a failure as I saw it consistently fail a few times on the same machine and then there were processes hanging around on that machine. @bnoordhuis can you help out so that we can decide if we can just delete the test or if its needs to be fixed ?

  13. Trott commented on Feb 2, 2017

    @Trott
    Trott
    on Feb 2, 2017
    Member

    Another one: https://ci.nodejs.org/job/node-test-commit-aix/3513/nodes=aix61-ppc64/console

    not ok 128 parallel/test-cluster-disconnect-handles
  ---
  duration_ms: 60.101
  severity: fail
  stack: |-
    timeout

  14. Trott commented on Jul 16, 2017

    @Trott
    Trott
    on Jul 16, 2017
    Member

    Test was moved to known_issues when _debugger was removed.

  15. Trott
    closed this as completedon Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    aixIssues and PRs related to the AIX platform.clusterIssues and PRs related to the cluster subsystem.freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions