Skip to content

Investigate flaky test-http-client-timeout-option-with-agent #22041

New issue
New issue
Closed
Closed
Investigate flaky test-http-client-timeout-option-with-agent#22041
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@oyyd
oyyd
opened on Jul 31, 2018
  • Version: v11.0.0-pre(master)
  • Platform: ubuntu1604_sharedlibs_debug_x64
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-linux-containered/5882/nodes=ubuntu1604_sharedlibs_debug_x64/console

11:15:20 not ok 833 parallel/test-http-client-timeout-option-with-agent
11:15:20   ---
11:15:20   duration_ms: 17.334
11:15:20   severity: fail
11:15:20   exitcode: 1
11:15:20   stack: |-
11:15:20     assert.js:84
11:15:20       throw new AssertionError(obj);
11:15:20       ^
11:15:20     
11:15:20     AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
11:15:20     + expected - actual
11:15:20     
11:15:20     - 4
11:15:20     + 3
11:15:20         at ClientRequest.req.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/parallel/test-http-client-timeout-option-with-agent.js:46:12)
11:15:20         at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/common/index.js:467:15)
11:15:20         at ClientRequest.emit (events.js:182:13)
11:15:20         at Socket.emitRequestTimeout (_http_client.js:669:40)
11:15:20         at Object.onceWrapper (events.js:273:13)
11:15:20         at Socket.emit (events.js:182:13)
11:15:20         at Socket._onTimeout (net.js:448:8)
11:15:20         at ontimeout (timers.js:454:11)
11:15:20         at tryOnTimeout (timers.js:326:5)
11:15:20         at listOnTimeout (timers.js:300:5)
11:15:20   ...

This test asserts the elapsed time of timeout in second units. But the actual timeout may be longer in some situations.

It seems that other related tests avoid measuring the elapsed time. I would like to modify this test to make it less likely fail and keep the consistency of these tests.

Activity

  1. maclover7
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    httpIssues and PRs related to the http subsystem.
    on Jul 31, 2018

  2. Trott commented on Aug 3, 2018

    @Trott
    Trott
    on Aug 3, 2018
    Member

    The main cause of failure here is almost certainly that it's a debug build, which makes everything run slooooowwwwer.....

  3. gdams
    closed this as completedin f8fda89on Aug 13, 2018
  4. rvagg
    added a commit that references this issue on Aug 15, 2018

    test: move test-http-client-timeout-option-with-agent to sequential

    3804836

  5. Trott commented on Aug 19, 2018

    @Trott
    Trott
    on Aug 19, 2018
    Member

    Alas, still flaky.

    https://ci.nodejs.org/job/node-test-commit-linux-containered/6421/nodes=ubuntu1604_sharedlibs_shared_x64/console

    00:15:46 not ok 2230 sequential/test-http-client-timeout-option-with-agent
00:15:46   ---
00:15:46   duration_ms: 5.26
00:15:46   severity: fail
00:15:46   exitcode: 1
00:15:46   stack: |-
00:15:46     assert.js:84
00:15:46       throw new AssertionError(obj);
00:15:46       ^
00:15:46     
00:15:46     AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:
00:15:46     
00:15:46     4 !== 3
00:15:46     
00:15:46         at ClientRequest.req.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_shared_x64/test/sequential/test-http-client-timeout-option-with-agent.js:46:12)
00:15:46         at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_shared_x64/test/common/index.js:460:15)
00:15:46         at ClientRequest.emit (events.js:182:13)
00:15:46         at Socket.emitRequestTimeout (_http_client.js:670:40)
00:15:46         at Object.onceWrapper (events.js:273:13)
00:15:46         at Socket.emit (events.js:182:13)
00:15:46         at Socket._onTimeout (net.js:449:8)
00:15:46         at ontimeout (timers.js:454:11)
00:15:46         at tryOnTimeout (timers.js:326:5)
00:15:46         at listOnTimeout (timers.js:300:5)
00:15:46   ...
  6. Trott
    reopened this on Aug 19, 2018
  7. Trott
    changed the title [-]test: possible flaky test-http-client-timeout-option-with-agent[/-] [+]Investigate flaky test-http-client-timeout-option-with-agent[/+] on Aug 19, 2018
  8. Trott
    added a commit that references this issue on Aug 19, 2018

    test: fix flaky http timeout test

    90f3e2f

  9. Trott commented on Aug 19, 2018

    @Trott
    Trott
    on Aug 19, 2018
    Member

    Proposed fix in #22403

  10. Trott
    added a commit that references this issue on Aug 21, 2018

    test: fix flaky http timeout test

    fd76a3d
  11. Trott
    closed this as completedin fd76a3don Aug 21, 2018
  12. targos
    added a commit that references this issue on Aug 21, 2018

    test: fix flaky http timeout test

    1bb0346
  13. targos
    added a commit that references this issue on Sep 3, 2018

    test: fix flaky http timeout test

    5aa3100
  14. firass111
    added a commit that references this issue on Apr 16, 2025

    test: move test-http-client-timeout-option-with-agent to sequential

    a7dad45
  15. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: move test-http-client-timeout-option-with-agent to sequential

    f8fda89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions