Repository navigation
drop visual studio 2015 support in CI #37472
Description
It seems building addons with VS2015 is not working now. Unfortunately the build output doesn't seem to contain useful information.
I thought we only support Visual Studio >= 2017 now in node-gyp.
Also, looks like this is the reason
https://ci.nodejs.org/job/node-test-binary-windows-native-suites/7515/nodes=win10-vcbt2015-COMPILED_BY-vs2019/console
16:08:09 `C:\\workspace\\node-test-binary-windows-native-suites\\node\\deps\\v8\\include\\v8.h(1426): error C2416: attribute 'deprecated("Use constructor with primitvie C++ types")' cannot be applied in this context [C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\addons\\02_function_arguments\\build\\addon.vcxproj]\r\n`Not sure node\\test\\addons\\02_function_arguments locations.
Originally posted by @gengjiawen in #37330 (comment)
Activity
gengjiawen commentedon Feb 22, 2021
cc @targos @nodejs/build-infra @nodejs/node-gyp @nodejs/platform-windows
richardlau commentedon Feb 22, 2021
Refs: https://github.com/nodejs/build/blob/master/doc/windows-visualstudio-supported-versions.md
cc @joaocgreis
gengjiawen commentedon Feb 22, 2021
And I am thinking For building Node.js Addons only support 2019 in upcoming v16.
joaocgreis commentedon Feb 23, 2021
For building addons, it's good to support as many versions as we can. Someone with VS2017 installed would have to upgrade to VS2019, and this can be a big issue for some users. But of course, this has to be balanced with our ability to maintain it.
Note that dropping a VS version includes editing BUILDING.md, updating CI, and adjusting node-gyp (see https://github.com/nodejs/node-gyp/blob/a78b584236e92a9469f72916c55ba83e9819ddea/lib/find-visualstudio.js#L348-L352).
targos commentedon Oct 5, 2022
I'd like to revisit this for Node.js 19 / V8 10.7
See #44741
gengjiawen commentedon Oct 5, 2022
tbh，I want to drop 2017 too. Since MSVC not fixing bugs timely or give useful feedback.
feat: remove support for VS2015 in Node.js >=19
targos commentedon Oct 7, 2022
PR in node-gyp: nodejs/node-gyp#2746
PR in build: nodejs/build#3049
deps: update V8 to 10.7.193.13