Repository navigation
webstreams: integrate into common stream utils #39316
Description
With the introduction of web streams, it would be good to integrate support into the various common stream utilities...
Refs: #39134
stream.finished()
const { finished } = require('stream');
finished(new ReadableStream(), (err) => { /* ... */ });
finished(new WritableStream(), (err) => { /* ... */ });
finished(new TransformStream(), (err) => { /* ... */ });import { finished } from 'stream/promises';
await finished(new ReadableStream());
await finished(new WritableStream());
await finished(new TransformStream());stream.pipeline()
const { pipeline } = require('stream');
pipeline(new ReadableStream(), new TransformStream(), new WritableStream(), (err) => { /* ... */ });import { pipeline } from 'stream/promises';
await pipeline(new ReadableStream(), new TransformStream(), new WritableStream());stream.addAbortSignal()
const { addAbortSignal } = require('stream');
const ac = new AbortController();
const readable = new ReadableStream();
addAbortSignal(ac.signal, readable);stream.compose()(stream: compose #39029)
Activity
mcollina commentedon Jul 9, 2021
As far as streams goes, this is probably a good first issue.
ronag commentedon Jul 12, 2021
No need to ask for permission. Just go ahead.
yolped commentedon Jul 26, 2021
Hello, I would like to assist on this issue. Can I get some more documentation and reading
jimmywarting commentedon Jul 27, 2021
Adapting pipeline to whatwg:streams feels almost a bit unnecessary, whatwg:streams are already kind of promise based already
I think i would never use pipeline and whatwg:streams together, I don't know so much about
finishedeither...ronag commentedon Aug 3, 2021
#39519 did add support for some of the things here but lacked tests so it was disabled. If someone wants to pick up this issue I would recommend looking at #39519, uncomment the web stream stuff, add tests and fix any remaining issue there.
mcollina commentedon Aug 3, 2021
The goal should be to add those for cross compatibility, so we can "pipe" from a WHATWG Stream to a Node.js Stream easily and without additional overhead.
evanrittenhouse commentedon Mar 21, 2022
@mcollina does this still need to be handled? I can take it if so, although will take me a while.
mcollina commentedon Aug 18, 2022
I think this is still unresolved. A PR adding support (or at a minimum tests) for this would be highly appreciated.
The use case these utilities are there to answer is to create interoperability between webstreams and nodestreams.
Marcellofabrizio commentedon Sep 20, 2022
@mcollina any documentation I can read to get more information on this? I feel like I can handle this as a first-timer.
25 remaining items
stream: enable usage of webstreams on compose()
debadree25 commentedon Feb 27, 2023
Implemented in:
finished()3225498pipeline()23effb2addAbortSignal()96c720ecompose()94e1f8fstream: enable usage of webstreams on compose()
stream: enable usage of webstreams on compose()
stream: add pipeline() for webstreams
stream: add abort signal for ReadableStream and WritableStream
stream: enable usage of webstreams on compose()