Investigate flaky test-gc-http-client-timeout

Test

test-gc-http-client-timeout

Platform

freebsd

Console output

not ok 873 parallel/test-gc-http-client-timeout
  ---
  duration_ms: 0.546
  severity: fail
  exitcode: 1
  stack: |-
    node:events:515
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect ECONNRESET 127.0.0.1:52005 - Local (127.0.0.1:53767)
        at internalConnect (node:net:999:16)
        at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)
        at GetAddrInfoReqWrap.emitLookup [as callback] (node:net:1145:9)
        at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:113:8)
    Emitted 'error' event on ClientRequest instance at:
        at Socket.socketErrorListener (node:_http_client:472:9)
        at Socket.emit (node:events:537:28)
        at emitErrorNT (node:internal/streams/destroy:151:8)
        at emitErrorCloseNT (node:internal/streams/destroy:116:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
      errno: -54,
      code: 'ECONNRESET',
      syscall: 'connect',
      address: '127.0.0.1',
      or...

Build links

https://ci.nodejs.org/job/node-test-commit-freebsd/44626/nodes=freebsd12-x64/testReport/junit/(root)/test/parallel_test_gc_http_client_timeout/

Additional information

No response

Related: #43956

Another failure

Build link: https://ci.nodejs.org/job/node-test-binary-armv7l/1095/RUN_SUBSET=js,label=debian10-armv7l/testReport/junit/(root)/test/parallel_test_gc_http_client_timeout/

Console output:

done/collected/total: 93/0/804
done/collected/total: 322/93/804
done/collected/total: 415/322/804
done/collected/total: 664/349/804
done/collected/total: 737/415/804
done/collected/total: 804/664/804
done/collected/total: 804/737/804
done/collected/total: 804/804/804
node:_http_server:498
    connections[i].socket.destroy();
                          ^

TypeError: Cannot read properties of null (reading 'destroy')
    at Server.closeIdleConnections (node:_http_server:498:27)
    at Server.close (node:_http_server:481:8)
    at Immediate.status (/home/iojs/build/workspace/node-test-binary-armv7l/test/parallel/test-gc-http-client-timeout.js:66:14)
    at process.processImmediate (node:internal/timers:471:21)

Node.js v19.0.0-pre

This failure is caused by #43522

This error case is fixed by #43949.

But the Error: connect ECONNRESET is still probably will happen, so I leave this issue open temporarily.

I think Error: connect ECONNRESET is triggered when the number of parallel connection is too many. By controlling this may fix it.

@theanarkh

I was able to replicate this issue by increasing the number of calls to getAll() as @theanarkh suggested, on MacOS 12.4.

Setting the number of calls to ~50 meant the test failed with Error: connect ECONNRESET almost 100% of the time.

Update: It's not just this test - when running tools/test.py sequential with just the set of test-gc-http-client*.js tests, its pretty random which test script fails.

The number of requests produced is non-deterministic, and will sometimes produce enough requests to trigger the error.

test: deflake gc-http-client tests by restricting number of requests

Navigation Menu

Repository navigation

Investigate flaky test-gc-http-client-timeout #43638

Test

Platform

Console output

Build links

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Investigate flaky test-gc-http-client-timeout #43638

Description

Test

Platform

Console output

Build links

Additional information

Activity

F3n67u commented on Jul 1, 2022

tniessen commented on Jul 23, 2022

F3n67u commented on Jul 24, 2022

theanarkh commented on Jul 25, 2022

nicksia-vgw commented on Aug 5, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions