Skip to content

fs,permission: make handling of buffers consistent - #52348

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:perm-fs-symlink-buffer-consistent
Apr 6, 2024
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:perm-fs-symlink-buffer-consistent

Conversation

@tniessen

@tniessen tniessen commented Apr 3, 2024

Copy link
Copy Markdown
Member

Commit 2000c26 added explicit handling of Buffers to fs.symlink, but not to fs.symlinkSync or fs.promises.symlink. This change adapts the latter two functions to behave like fs.symlink.

Refs: #49156
Refs: #51212

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. security Issues and PRs related to security.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants