[gurgunday]

Add a new StatementSync method setReturnArrays() that allows query results to be returned as arrays instead of objects. This is more efficient when column names are meaningless, auto-generated, or when working with hundreds of columns.

Fixes #57534

It's my first significant C++ PR, hopefully first of many :)

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[anonrig]

Cc @nodejs/cpp-reviewers

[codecov]

Codecov Report

Attention: Patch coverage is 85.85859% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (32e5e81) to head (5420ed5).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.85%	0 Missing and 14 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57542      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      184990   185042      +52     
  Branches    36214    36232      +18     
==========================================
+ Hits       166941   167008      +67     
+ Misses      11002    10996       -6     
+ Partials     7047     7038       -9     

Files with missing lines	Coverage Δ
src/node_sqlite.h	63.63% <ø> (ø)
src/node_sqlite.cc	80.52% <85.85%> (+<0.01%)	⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cjihrig]

Oh, and this needs documentation.

[gurgunday]

I'll add docs once the code is approved

[cjihrig]

I've opened #57569 to refactor the iterator implementation. I think we should land that PR before this one so that we can avoid exposing iterator internal state to JS.

[cjihrig]

This needs a rebase, but we can finally move this forward.

[gurgunday]

Yep, will rebase asap

[nodejs-github-bot]

Landed in 054371d

[tniessen]

@gurgunday @cjihrig Was there any discussion of how the internal state of a StatementSync (i.e., whether it will return an array or an object) should be reflected in the TypeScript declarations?