http: increase keepAliveTimeout default to 65 seconds by pimterry · Pull Request #62782 · nodejs/node

pimterry · 2026-04-16T21:05:53Z

This PR takes the code from #59203 (now stalled) and fixes it up to get the tests & linting passing so we can hopefully merge just in time for v26. Conclusion there I think it this is possibly semver-major, we're not 100% sure but better to release with a major bump initially at least.

See discussion there for context. I've kept @pras529 as a co-author on the commit.

nodejs-github-bot · 2026-04-16T21:05:59Z

Review requested:

@nodejs/http
@nodejs/net

Co-authored-by: Prashant Bansal <prashantbansal529@gmail.com> Signed-off-by: Tim Perry <pimterry@gmail.com>

codecov · 2026-04-16T23:00:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (2071c44) to head (a110f7e).
⚠️ Report is 143 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62782      +/-   ##
==========================================
- Coverage   89.68%   89.68%   -0.01%     
==========================================
  Files         706      706              
  Lines      218143   218191      +48     
  Branches    41732    41741       +9     
==========================================
+ Hits       195650   195693      +43     
- Misses      14402    14423      +21     
+ Partials     8091     8075      -16

Files with missing lines	Coverage Δ
lib/_http_server.js	`97.06% <100.00%> (-0.22%)`	⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-04-17T02:44:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72731/

nodejs-github-bot · 2026-04-17T08:50:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72736/

nodejs-github-bot · 2026-04-20T10:08:10Z

Commit Queue failed

- Loading data for nodejs/node/pull/62782
✔  Done loading data for nodejs/node/pull/62782
----------------------------------- PR info ------------------------------------
Title      http: increase keepAliveTimeout default to 65 seconds (#62782)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     pimterry:keepalive-timeout-65s -> nodejs:main
Labels     http, semver-major, author ready, needs-ci
Commits    1
 - http: increase keepAliveTimeout default to 65 seconds
Committers 1
 - Tim Perry <pimterry@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62782
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62782
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Apr 2026 21:05:53 GMT
   ✔  Approvals: 4
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/62782#pullrequestreview-4125720099
   ✔  - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/62782#pullrequestreview-4129058692
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/62782#pullrequestreview-4132919093
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/62782#pullrequestreview-4134117996
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-17T08:50:28Z: https://ci.nodejs.org/job/node-test-pull-request/72736/
- Querying data for job/node-test-pull-request/72736/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24660527138

pimterry · 2026-04-20T11:14:12Z

@nodejs/tsc can you take a look at this semver-major please? See #59203 for context.

nodejs-github-bot · 2026-04-20T17:17:30Z

Commit Queue failed

- Loading data for nodejs/node/pull/62782
✔  Done loading data for nodejs/node/pull/62782
----------------------------------- PR info ------------------------------------
Title      http: increase keepAliveTimeout default to 65 seconds (#62782)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     pimterry:keepalive-timeout-65s -> nodejs:main
Labels     http, semver-major, author ready, needs-ci
Commits    1
 - http: increase keepAliveTimeout default to 65 seconds
Committers 1
 - Tim Perry <pimterry@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62782
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62782
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Apr 2026 21:05:53 GMT
   ✔  Approvals: 5
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/62782#pullrequestreview-4125720099
   ✔  - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/62782#pullrequestreview-4129058692
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/62782#pullrequestreview-4132919093
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/62782#pullrequestreview-4134117996
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/62782#pullrequestreview-4141787491
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-20T10:08:10Z: https://ci.nodejs.org/job/node-test-pull-request/72736/
- Querying data for job/node-test-pull-request/72736/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24680062576

pimterry · 2026-04-26T11:24:10Z

This is still waiting for a 2nd @nodejs/tsc approval if anybody has a minute. Sorry, I thought there were 2 before my latest commit queue but I was wrong, this is still blocked 😬

panva

RSLGTM

nodejs-github-bot · 2026-04-26T15:14:43Z

Landed in 9f75269

PR nodejs#62782 updated the keepAliveTimeout default from 5s to 65s and correctly updated server.keepAliveTimeout (line 2006), but the http.createServer() options table at line 3775 was not updated. Fix the remaining reference to reflect the current default of 65000ms. Signed-off-by: Jahanzaib iqbal <jahanzaib@gsoftconsulting.com>

PR #62782 updated the keepAliveTimeout default from 5s to 65s and correctly updated server.keepAliveTimeout (line 2006), but the http.createServer() options table at line 3775 was not updated. Fix the remaining reference to reflect the current default of 65000ms. Signed-off-by: Jahanzaib iqbal <jahanzaib@gsoftconsulting.com> PR-URL: #63974 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Notable changes: async_hooks: * (SEMVER-MAJOR) remove legacy AsyncLocalStorage implementation (Matteo Collina) #63641 benchmark: * (SEMVER-MAJOR) protect against accidental fork bomb (James M Snell) #66132 build: * (SEMVER-MAJOR) remove the bundled FIPS provider build (Filip Skokan) #64777 * (SEMVER-MAJOR) require OpenSSL 3 or later (Filip Skokan) #64777 * (SEMVER-MAJOR) downgrade Intel macOS support to experimental (Antoine du Hamel) #65427 crypto: * (SEMVER-MAJOR) move DEP0093 to End-of-Life (Filip Skokan) #64777 * (SEMVER-MAJOR) remove legacy OpenSSL code paths (Filip Skokan) #64777 * (SEMVER-MAJOR) validate digest output encodings (Filip Skokan) #66247 * (SEMVER-MAJOR) validate update input encodings (Filip Skokan) #66247 * (SEMVER-MAJOR) validate inputEncoding in Cipher/Decipher update (Maruthan G) #66247 * (SEMVER-MAJOR) move DEP0198 to End-of-Life (Filip Skokan) #64000 * (SEMVER-MAJOR) move DEP0203 and DEP0204 to End-of-Life (Filip Skokan) #63188 * (SEMVER-MAJOR) reject resizable backing stores in Web Crypto buffer parameters (Filip Skokan) #63925 * (SEMVER-MAJOR) throw on uninitialized DH computeSecret (Filip Skokan) #63922 * (SEMVER-MAJOR) runtime-deprecate calling Hmac.digest() more than once (Madelyn) #63624 crypto,https,tls: * (SEMVER-MAJOR) end OpenSSL engine support (Filip Skokan) #64777 deps: * (SEMVER-MAJOR) update archs files for openssl-4.1.0 (Node.js GitHub Bot) #66971 * (SEMVER-MAJOR) upgrade openssl sources to openssl-4.1.0 (Node.js GitHub Bot) #66971 * (SEMVER-MAJOR) remove ncrypto legacy OpenSSL backend (Filip Skokan) #64777 * (SEMVER-MAJOR) update V8 to 15.6.75.13 (Joyee Cheung) #66601 * (SEMVER-MAJOR) update V8 to 15.5.35.20 (Joyee Cheung) #66537 * (SEMVER-MAJOR) update V8 to 15.2.124.38 (Joyee Cheung) #65161 * (SEMVER-MAJOR) upgrade npm to 12.1.0 (npm team) #66212 dgram: * (SEMVER-MAJOR) skip the custom lookup for literal IP addresses (Ruben Bridgewater) #64131 dns: * (SEMVER-MAJOR) do not consult hosts file in reverse lookups (Archkon) #64268 * (SEMVER-MAJOR) stop using deprecated functions in `SetServers` (Antoine du Hamel) #64356 doc: * (SEMVER-MAJOR) remove OpenSSL 1.x references (Filip Skokan) #64777 * (SEMVER-MAJOR) update Node.js 27 official binary toolchains (Richard Lau) #66377 domain: * (SEMVER-MAJOR) runtime-deprecate the module (Matteo Collina) #65074 * (SEMVER-MAJOR) port to AsyncLocalStorage (Matteo Collina) #61095 fs: * (SEMVER-MAJOR) implement glob natively (Aviv Keller) #65392 * (SEMVER-MAJOR) return Buffer from mkdtemp when prefix is a Buffer (Hamid Reza Ghavami) #64397 http: * (SEMVER-MAJOR) reject responses exceeding header limit (Matteo Collina) #65010 * (SEMVER-MAJOR) runtime deprecate instantiating without new (Yagiz Nizipli) #64853 * (SEMVER-MAJOR) increase keepAliveTimeout default to 65 seconds (Tim Perry) #62782 * (SEMVER-MAJOR) make req.headers have a null prototype (Matteo Collina) #62900 * (SEMVER-MAJOR) reject addTrailers after finish (Ryuhei Shima) #62832 http2: * (SEMVER-MAJOR) increase default window sizes (Matteo Collina) #64623 lib: * (SEMVER-MAJOR) deprecate _http_* (Sebastian Beltran) #58535 * (SEMVER-MAJOR) insert argv[0] at argv[1] in setDeserializeMainFunction (Daijiro Wachi) #62928 * (SEMVER-MAJOR) use `Object.freeze` to avoid defensive cloning in `SourceMap` (Daijiro Wachi) #62830 * (SEMVER-MAJOR) reject SharedArrayBuffer in Blob constructor per spec (Ali Hassan) #63046 lib,src: * (SEMVER-MAJOR) remove `--no-experimental-websocket` CLI flag (Antoine du Hamel) #65284 net: * (SEMVER-MAJOR) race family autoselection attempts (Matteo Collina) #66229 * (SEMVER-MAJOR) throw on multiple listen calls (Matteo Collina) #64871 * (SEMVER-MAJOR) runtime-deprecate Server.prototype._listen2 (Guilherme Araújo) #64794 * (SEMVER-MAJOR) add experimental net/promises API (Ethan Arrowood) #63965 repl: * (SEMVER-MAJOR) use inspector over vm (Aviv Keller) #64034 src: * (SEMVER-MAJOR) officially deprecate `node::ObjectWrap` (Anna Henningsen) #63756 * (SEMVER-MAJOR) merge `CreateEnvironment()` overloads (Anna Henningsen) #63596 src, test: src,lib: * (SEMVER-MAJOR) add --allow-env permission (James M Snell) #66132 stream: * (SEMVER-MAJOR) destroy source when map iterator closes early (Y1D7NG) #64264 test: * (SEMVER-MAJOR) fix fs write encoding coverage (Filip Skokan) #66247 test,benchmark: * (SEMVER-MAJOR) drop OpenSSL 1.x-only coverage (Filip Skokan) #64777 test,tools: * (SEMVER-MAJOR) drop OpenSSL 1.x-era FIPS leftovers (Filip Skokan) #64777 test_runner: * use AsyncLocalStorage instead of async_hooks (Matteo Collina) #66795 tls: * (SEMVER-MAJOR) move _tls_* to end-of-life (Sebastian Beltran) #60658 zlib: * (SEMVER-MAJOR) convert classes to modern syntax and eol DEP0184 (Yagiz Nizipli) #64849 PR-URL: #67062

nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Apr 16, 2026

http: increase keepAliveTimeout default to 65 seconds

a110f7e

Co-authored-by: Prashant Bansal <prashantbansal529@gmail.com> Signed-off-by: Tim Perry <pimterry@gmail.com>

pimterry force-pushed the keepalive-timeout-65s branch from b63c40b to a110f7e Compare April 16, 2026 21:12

pimterry mentioned this pull request Apr 16, 2026

Increase default keepAliveTimeout to 65s #59203

Closed

pimterry requested review from BethGriggs and RafaelGSS April 16, 2026 21:24

meixg approved these changes Apr 17, 2026

View reviewed changes

meixg added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 17, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 17, 2026

BethGriggs approved these changes Apr 17, 2026

View reviewed changes

JungMinu approved these changes Apr 18, 2026

View reviewed changes

gurgunday approved these changes Apr 18, 2026

View reviewed changes

gurgunday added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 18, 2026

pimterry added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 20, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 20, 2026

richardlau approved these changes Apr 20, 2026

View reviewed changes

pimterry added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Apr 20, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 20, 2026

trivikr approved these changes Apr 20, 2026

View reviewed changes

panva approved these changes Apr 26, 2026

View reviewed changes

pimterry added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Apr 26, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 26, 2026

nodejs-github-bot merged commit 9f75269 into nodejs:main Apr 26, 2026
91 of 92 checks passed

claude Bot mentioned this pull request Jun 6, 2026

node:http: rewrite the client on net/tls + llhttp (Node http suite: ~55% → 82.3%, +182 vendored tests, client proxy support) oven-sh/bun#31587

Merged

jahanzaib-iqbal-dev mentioned this pull request Jun 18, 2026

doc: fix keepAliveTimeout default in http.createServer options #63974

Merged

jongjun-park-imweb-me mentioned this pull request Sep 1, 2026

feat(node): add a keepAliveTimeout option to the standalone server withastro/astro#17883

Open

RafaelGSS mentioned this pull request Oct 27, 2026

2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha) #67062

Open

Navigation Menu

Repository navigation

http: increase keepAliveTimeout default to 65 seconds - #62782

http: increase keepAliveTimeout default to 65 seconds#62782
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pimterry:keepalive-timeout-65s

pimterry commented Apr 16, 2026

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

nodejs-github-bot commented Apr 20, 2026

Uh oh!

pimterry commented Apr 20, 2026

Uh oh!

nodejs-github-bot commented Apr 20, 2026

Uh oh!

pimterry commented Apr 26, 2026

Uh oh!

panva left a comment

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

pimterry commented Apr 16, 2026

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

nodejs-github-bot commented Apr 17, 2026

Uh oh!

nodejs-github-bot commented Apr 20, 2026

Uh oh!

pimterry commented Apr 20, 2026

Uh oh!

nodejs-github-bot commented Apr 20, 2026

Uh oh!

pimterry commented Apr 26, 2026

Uh oh!

panva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov Bot commented Apr 16, 2026 •

edited

Loading