Do not parse numbers on url parsers - ipv4  #36

Activity

1. anonrig

   added

   good first issueGood for newcomersGood for newcomers

   help wantedExtra attention is neededExtra attention is needed

   on Jan 16, 2023
2. debadree25 commented on Jan 16, 2023

   

   debadree25

   on Jan 16, 2023

   More actions

   So basically instead of int64_t num = ParseIPv4Number(last_str, last_str + last.size()); we would just use a validator here?
3. anonrig commented on Jan 16, 2023

   

   anonrig

   on Jan 16, 2023

   MemberAuthor

   More actions

   There are 2 optimizations can be done here.

   1. Removing vector initialization on line 412

   std::vector<std::string> parts = SplitString(input, '.', false);
   

   2. Removing ParseIPv4Number and replacing it with a validator that returns boolean

   int64_t num = ParseIPv4Number(last_str, last_str + last.size());
   
4. debadree25 commented on Jan 16, 2023

   

   debadree25

   on Jan 16, 2023

   More actions

   Understood! Thanks! will attempt this!
5. miguelteixeiraa

   added a commit that references this issue on Jan 16, 2023

   src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid

   ...

   ff9c478
6. miguelteixeiraa commented on Jan 16, 2023

   

   miguelteixeiraa

   on Jan 16, 2023

   More actions

   I'm really sorry @debadree25 ! : ((
   I was already working on it and should have commented something here.
   I apologize for that

   👍React with 👍2Reacted by Debadree Chatterjee and Tony Gorez
7. debadree25 commented on Jan 17, 2023

   

   debadree25

   on Jan 17, 2023

   More actions

   I'm really sorry @debadree25 ! : (( I was already working on it and should have commented something here. I apologize for that

   No issue at all checking out your PR to learn!!

   ❤️React with ❤️2Reacted by Miguel Teixeira and Tony Gorez
8. nodejs-github-bot

   added a commit that references this issue on Jan 23, 2023

   src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid

   ...

   762a3a8
9. anonrig

   closed this as completedon Jan 23, 2023
10. ruyadorno

    added a commit that references this issue on Feb 1, 2023

    src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid

    ...

    640d111
11. juanarbol

    added 2 commits that reference this issue on Mar 3, 2023

    src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid

    ...

    8d90f5c

    src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid

    ...

    b06298c