Skip to content

Add flyctl to the default software registry - #142

Open
phenaproxima wants to merge 2 commits into
php-internal:1.xfrom
phenaproxima:add-flyctl-registry
Open

phenaproxima wants to merge 2 commits into
php-internal:1.xfrom
phenaproxima:add-flyctl-registry

Conversation

@phenaproxima

Copy link
Copy Markdown
Contributor

Adds flyctl to the default software registry, as requested in #139.

Notes on the entry:

  • Asset pattern /^flyctl_.*/ matches the release assets (flyctl_0.4.115_macOS_arm64.tar.gz, etc.); the asset selection rules already exclude the _checksums.txt file.
  • Binary pattern /^flyctl(?:\\.exe)?$/ matches exactly the binary: the tarballs contain a lone flyctl, and the Windows zip contains flyctl.exe plus a wintun.dll helper that must not match.
  • Binary name is fly, not flyctl: dload renames the extracted binary to the configured name (keeping the real extension), so it lands as fly / fly.exe — matching the command name used throughout the fly.io docs. This also makes dload's existence checks and PATH lookups find a globally installed fly.

Closes #139

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adam G-H (phenaproxima) and others added 2 commits October 10, 2026 04:15
The binary is renamed to `fly` on extraction to match the command name
used throughout the fly.io docs. On Windows it lands as `fly.exe`.

Closes php-internal#139
The Windows release archive ships wintun.dll next to flyctl.exe; without it, commands that open a WireGuard tunnel (fly proxy, fly ssh console) fail.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk force-pushed the add-flyctl-registry branch from d71de5e to 7794151 Compare October 10, 2026 00:21
@roxblnfk

Copy link
Copy Markdown
Member

@phenaproxima a question about the binary name: the entry installs the executable as fly, while the archive ships flyctl and the software alias is flyctl too. Was the rename intentional?

I see the Fly docs use fly as the main command, but their installer also keeps flyctl, and a lot of CI examples call flyctl deploy. Someone who adds <download software="flyctl"/> would probably expect ./flyctl to exist. Would keeping flyctl as binary.name work for your use case, or do you rely on fly?

@phenaproxima

phenaproxima commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

I don't feel particularly strongly about it; flyctl would be fine. The reason I changed it to fly was to match fly.io's documentation, which refers to the utility as fly every time. So that was just an attempt to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flyctl to the default software registry

2 participants