Maybe related to this issue #1884 but multi line attributes do not add the trailing comma, which is added everywhere else including constructor arguments. However, it is not added to multi line attributes.
Using PHP8 with mutli line attributes result in formatting like this by prettier:
#[
ORM\Column(...),
ORM\CustomIdGenerator(class: ...),
ORM\GeneratedValue(strategy: 'CUSTOM'),
ORM\Id
]
private string $id;but I think it should be:
#[
ORM\Column(...),
ORM\CustomIdGenerator(class: ...),
ORM\GeneratedValue(strategy: 'CUSTOM'),
ORM\Id,
]
private string $id;or actually if #1884 is taken into account:
#[
ORM\Column(...),
ORM\CustomIdGenerator(class: ...),
ORM\GeneratedValue(strategy: 'CUSTOM'),
ORM\Id,
]
private string $id;Prettier 2.5.1
PHP Plugin 0.17.6
.prettierrc
{
"$schema": "http://json.schemastore.org/prettierrc",
"arrowParens": "always",
"braceStyle": "psr-2",
"bracketSameLine": false,
"bracketSpacing": true,
"phpVersion": "8.0",
"printWidth": 120,
"singleQuote": true,
"tabWidth": 4,
"trailingComma": "es5",
"trailingCommaPHP": true
}
I think it is a bug, isn't it?
Maybe related to this issue #1884 but multi line attributes do not add the trailing comma, which is added everywhere else including constructor arguments. However, it is not added to multi line attributes.
Using PHP8 with mutli line attributes result in formatting like this by prettier:
#[ ORM\Column(...), ORM\CustomIdGenerator(class: ...), ORM\GeneratedValue(strategy: 'CUSTOM'), ORM\Id ] private string $id;but I think it should be:
#[ ORM\Column(...), ORM\CustomIdGenerator(class: ...), ORM\GeneratedValue(strategy: 'CUSTOM'), ORM\Id, ] private string $id;or actually if #1884 is taken into account:
#[ ORM\Column(...), ORM\CustomIdGenerator(class: ...), ORM\GeneratedValue(strategy: 'CUSTOM'), ORM\Id, ] private string $id;Prettier 2.5.1
PHP Plugin 0.17.6
.prettierrc{ "$schema": "http://json.schemastore.org/prettierrc", "arrowParens": "always", "braceStyle": "psr-2", "bracketSameLine": false, "bracketSpacing": true, "phpVersion": "8.0", "printWidth": 120, "singleQuote": true, "tabWidth": 4, "trailingComma": "es5", "trailingCommaPHP": true }I think it is a bug, isn't it?