archive: Tarballer.Go: suppress io.ErrClosedPipe logs on close

[thaJeztah]

Before this patch:

go test -v -run TestCopyCaseI
=== RUN   TestCopyCaseI
    copy_unix_test.go:117: copying from "/tmp/T/TestCopyCaseI2681583485/001/archive-copy-test2002515556/dir1/." to "/tmp/T/TestCopyCaseI2681583485/001/archive-copy-test3740527566/file1" (not follow symbol link)
    copy_unix_test.go:123: copying from "/tmp/T/TestCopyCaseI2681583485/001/archive-copy-test3740527566/dirSymlink" to "/tmp/T/TestCopyCaseI2681583485/001/archive-copy-test3740527566/file1" (follow symbol link)
ERRO[0000] Can't add file /tmp/T/TestCopyCaseI2681583485/001/archive-copy-test3740527566/dir1 to tar: io: read/write on closed pipe
ERRO[0000] Can't close tar writer: io: read/write on closed pipe
ERRO[0000] Can't add file /tmp/T/TestCopyCaseI2681583485/001/archive-copy-test2002515556/dir1/. to tar: io: read/write on closed pipe
ERRO[0000] Can't close tar writer: io: read/write on closed pipe
--- PASS: TestCopyCaseI (0.01s)
PASS
ok  	github.com/moby/go-archive	0.828s

After this test, the "closed pipe" errors are ignored when closing;

go test -v -run TestCopyCaseI
=== RUN   TestCopyCaseI
    copy_unix_test.go:117: copying from "/tmp/T/TestCopyCaseI1855397298/001/archive-copy-test1695505150/dir1/." to "/tmp/T/TestCopyCaseI1855397298/001/archive-copy-test1369902297/file1" (not follow symbol link)
    copy_unix_test.go:123: copying from "/tmp/T/TestCopyCaseI1855397298/001/archive-copy-test1369902297/dirSymlink" to "/tmp/T/TestCopyCaseI1855397298/001/archive-copy-test1369902297/file1" (follow symbol link)
ERRO[0000] Can't add file /tmp/T/TestCopyCaseI1855397298/001/archive-copy-test1695505150/dir1/. to tar: io: read/write on closed pipe
ERRO[0000] Can't add file /tmp/T/TestCopyCaseI1855397298/001/archive-copy-test1369902297/dir1 to tar: io: read/write on closed pipe
--- PASS: TestCopyCaseI (0.01s)
PASS
ok  	github.com/moby/go-archive	0.413s

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.93%. Comparing base (216738e) to head (1bec7ec).
⚠️ Report is 65 commits behind head on main.

Files with missing lines	Patch %	Lines
archive.go	0.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   65.81%   64.93%   -0.89%     
==========================================
  Files          42       44       +2     
  Lines        2039     2270     +231     
==========================================
+ Hits         1342     1474     +132     
- Misses        519      595      +76     
- Partials      178      201      +23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR reduces log noise during tarball creation by suppressing io.ErrClosedPipe errors that can occur when closing the tar, compression, or pipe writers after the reader side has already been closed (e.g., during tests like TestCopyCaseI).

Changes:

• Ignore io.ErrClosedPipe from ta.TarWriter.Close() to avoid redundant error logs on shutdown.
• Ignore io.ErrClosedPipe from t.compressWriter.Close() to avoid redundant error logs on shutdown.
• Ignore io.ErrClosedPipe from t.pipeWriter.Close() to avoid redundant error logs on shutdown.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[thaJeztah]

Looking for these logs; I see they were changed to Error in 3c7c468, which ... describes exactly the opposite for most of these (it was debug before that);

• Clean redundant error message for export moby#20492

[thaJeztah]

Probably a Warnf (at most) would be appropriate for these? Thoughts @vvoland ?

[vvoland]

SGTM