Repository navigation
Conversation
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for documenting this migration—it will be especially useful with the iOS 27 lifecycle requirements. One small housekeeping request: could we update the prerequisite link from the closed umbrella PR #53744 to the landed implementation PR #57700? There are also two trailing-whitespace lines in docs/releases/release-levels.md that cause git diff --check to fail.
|
also, there are conflicts that needs to be resolved. |
|
Thanks for the review! I addressed the comments and merged the current |
|
|
||
| <Tabs groupId="ios-language" queryString defaultValue={constants.defaultAppleLanguage} values={constants.appleLanguages}> | ||
| <TabItem value="objc"> | ||
|
|
There was a problem hiding this comment.
There is still trailing whitespace on this blank line and the corresponding blank line at line 58, so git diff --check fails. Could you remove the spaces from both lines?
|
One final housekeeping item: the PR description still says this depends on the closed umbrella PR react-native#53744. Could you update it to reference the landed implementation PR react-native#57700 instead? |
|
Absolutely - done |
This PR adjusts documentation to reflect changes needed to adopt SceneDelegate.
This PR should be merged after the following PR to React Native is merged: react/react-native#57700