Repository navigation
Fix scaled and clipped Android safe-area insets (#58997) - #58997
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124663000. |
Abbondanzo
force-pushed
the
export-D124663000
branch
from
October 12, 2026 14:50
f368446 to
6e234d4
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 12, 2026
Summary: Safe-area insets measure how far a view's rendered bounds extend into the unsafe area, in Android dp or iOS points. Views with the same rendered bounds should report the same insets, regardless of scale or content padding. Fix Android's calculation to use the full transformed bounds instead of mixing a clipped origin with untransformed dimensions, and preserve fractional values through the single density conversion. The example compares a 1× root and a 2× observer without applying padding. iOS native behavior is unchanged. Changelog: [Android][Fixed] - Correct safe-area inset measurements for scaled views and views clipped by ancestors. Differential Revision: D124663000
Summary: Safe-area insets measure how far a view's rendered bounds extend into the unsafe area, in Android dp or iOS points. Views with the same rendered bounds should report the same insets, regardless of scale or content padding. Fix Android's calculation to use the full transformed bounds instead of mixing a clipped origin with untransformed dimensions, and preserve fractional values through the single density conversion. The example compares a 1× root and a 2× observer without applying padding. iOS native behavior is unchanged. Changelog: [Android][Fixed] - Correct safe-area inset measurements for scaled views and views clipped by ancestors. Reviewed By: fkgozali Differential Revision: D124663000
Abbondanzo
force-pushed
the
export-D124663000
branch
from
October 12, 2026 17:46
6e234d4 to
af66d58
Compare
|
This pull request has been merged in 9641acd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Safe-area insets measure how far a view's rendered bounds extend into the unsafe area, in Android dp or iOS points. Views with the same rendered bounds should report the same insets, regardless of scale or content padding. Fix Android's calculation to use the full transformed bounds instead of mixing a clipped origin with untransformed dimensions, and preserve fractional values through the single density conversion. The example compares a 1× root and a 2× observer without applying padding. iOS native behavior is unchanged.
Changelog:
[Android][Fixed] - Correct safe-area inset measurements for scaled views and views clipped by ancestors.
Reviewed By: fkgozali
Differential Revision: D124663000