Repository navigation
Use rb_len_t for String lengths in cgi/escape - #138
Merged
Merged
Conversation
It falls back to long on Ruby versions that do not define HAVE_RB_LEN_T, so the change also builds there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports ruby/ruby@939f20c79d from ruby/ruby#19288, which switched the String lengths in
cgi/escapetorb_len_t. After this,ext/cgi/escape/escape.cis identical to the one in ruby/ruby master.Ruby versions that do not define
HAVE_RB_LEN_Tgetrb_len_tas a typedef oflong, so nothing changes there. I ranbundle exec rake testwith mswin builds of Ruby 3.3, 3.4, 4.0 and a 4.1.0dev snapshot that definesHAVE_RB_LEN_T.Generated with Claude Code