Repository navigation
Conversation
…es apply Retired routes live on only as HTML redirect stubs with no .md twin, so an agent following the llms.txt advice to append .md got a 404. Each retired route's .md URL now 301s to its replacement's .md, and verify:routes checks every one lands on a built Markdown file. The environment variables page now says a Space variable change needs no republish, a team variable change waits for each Space's next publish, and secrets reach server code but not templates.
Contributor
|
No issues found.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two problems from Komunite's docs feedback.
.mdURLs for retired pages returned 404llms.txt tells agents to "append
.mdto any docs URL". Retired routes such as/docs/configuration,/docs/redirects,/docs/access-controland/docs/custom-domainsonly exist as Blume meta-refresh HTML stubs, and moved pages leave no file behind. Neither has a Markdown twin, so/docs/configuration.mdreturned 404 while/docs/configurationworked in a browser.redirect-rules.mjsnow emits a real 301 for every entry inredirects.tsand every authored rule, from<from>.mdto<to>.md. A#fragmentis dropped, and/maps to/index.md. Examples:/docs/configuration.md→/docs/config-file.md/docs/api/docs.md→/docs/api/reference.md/docs/collab.md→/docs/index.mdverify:routesasserts that each of the 76 rules compiles to a 301 with the expected target and that the target is a built Markdown file. Before writing this, I checked that every target's.mdreturns 200 in production today.Budget: the routing rule count goes from 1,857 to 1,933 (1,925 static, cap 2,000), which leaves 75 static rules of headroom.
Env var page: when a change applies
The callout said a write "applies at the next finalize, which the write itself queues". That reads as "republish". It now says:
This matches the control plane. Space writes call
createSpaceVariableRuntimeSync, which forces a settings version. Team writes go throughapplyVariableUpsertwith no sync, and thesetTeamVariablecontract already says "applies when a version next finalizes". The lanes section also now states that plain variables reach both templates and server code, while secrets reach only server code; a template that references a secret is blocked withsecret_variable_in_template.Checks
bun run buildandbun run verify:routespass.verify:public-safetyandverify:prose(Vale 3.17.1) are clean.test:docs: 27/28 pass. The one failure (openapi-prose-scope, "allows compatibility protocol terms only in compatibility API prose") also fails onmainin this environment.Companion monorepo PR: spacefast/monorepo#4637. It makes
sf docssearch every doc and points the catalog's links at live pages instead of these retired routes. After that CLI ships, thesf docssection incli/agent-commands.mdx(the--fullsearch example) needs a follow-up; it isn't in this PR because docs only describe shipped behavior.Tag
@indentto continue the conversation here.Need help on this PR? Tag
@codesmith-botwith what you need.