Skip to content

Distinguish domain deletion from removing a Space assignment - #93

Open
Kn0ax wants to merge 1 commit into
mainfrom
docs/domain-delete
Open

Kn0ax wants to merge 1 commit into
mainfrom
docs/domain-delete

Conversation

@Kn0ax

@Kn0ax Kn0ax commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove sf domains delete from the sf domains rm alias list.
  • Document that sf domains delete removes the team's domain record and any Spacefast-hosted DNS zone, including confirmation, deletion blockers, and the --space migration.
  • Refresh only the domain-removal command entries in the producer-owned CLI reference. The export uses the original reference's producer baseline with the domain-deletion changes applied, so unrelated command updates are excluded. The generated reference also contained the unsafe alias, so changing only the authored page would leave conflicting search and Ask AI guidance.

Coordinate this documentation rollout with the CLI behavior change. Publish the corrected docs and corpus before releasing the destructive command, and refresh the API's bundled corpus from this docs revision.

Validation

Passed with Bun 1.3.11 and Node.js 26:

  • bun install --frozen-lockfile
  • bun run verify:generated
  • bun run check
  • bun run validate
  • bun run build
  • bun run audit
  • bun run verify:public-safety
  • bun run verify:prose
  • bun run verify:routes
  • bun run test:docs (28 passed)

View in Indent
Tag @indent to continue the conversation here.


View with [code]smith Generate Proof with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@indent

indent Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Issues

All clear! No issues remaining. 🎉

1 issue already resolved
  • The page intro in content/cli/domains.mdx says every command takes --space and --claim-token, with only sf routing inspect excepted. The new sf domains delete section says it no longer accepts --space, so the page contradicts itself. (fixed by commit 2443717)
    Found by Indent Review Agent

CI Checks

All required CI checks passed on 2443717.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found
Full results

Indent Review Agent

  • Summary: No issues found
  • Last ran on commit: 24437174
  • Latest result
    {
      "summary": "No issues found",
      "findings": []
    }

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 82ce821e-af00-48a8-8e4e-78162426536e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch was successfully deployed

1 active deployment
preview/docs/domain-delete — 24437174 Deployed Oct 29, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant