You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(init): point the install trailer at the Taskless skill only - #501
After a successful install, taskless init (and the wizard) printed a trailer that branched on whether the /tskl command was installed, and in both forms told the user to run /tskl onboard and/or a pinned npx @taskless/cli-nightly@… onboard from the terminal. That is more than the user needs and leaks a version-pinned command into the first thing they read.
The trailer is now a single line for every install plan:
In your AI tool, you can use the Taskless skill now - just ask to onboard with Taskless to set up starter rules for your codebase and get a report of what Taskless can catch.
getOnboardTrailer() takes no arguments; init and the wizard stop computing commandsInstalled for it (the init --json field is unchanged).
cli-init spec: the trailer requirement and its scenarios now describe the single skill-only line.
Tests assert the new line, and that it mentions neither /tskl onboard nor a CLI onboard command.
Review: fix(init): point the install trailer at the Taskless skill only
Review mode: incremental — read 0 prior review thread(s) before reviewing. .prior-review.json contains no prior inline threads, review summaries, or top-level comments beyond the trigger itself, so this is the first review of this PR.
Summary: Clean, well-scoped change. getOnboardTrailer() drops its commandsInstalled argument and returns a single fixed string; both call sites (init.ts, wizard/index.ts) are updated; the cli-init spec delta correctly restates the full requirement text (not just the diff) along with both scenarios; tests assert the new wording and the absence of /tskl onboard and the pinned onboard command; a patch changeset is included.
Checked for issues that often accompany this kind of change:
commandsInstalled is still computed and exposed on the init --json envelope (init.ts:114,389,476) — correctly left alone per the PR description, only the trailer-building usage was removed.
getCliPrefix import is still used elsewhere in both onboard.ts (line 93) and wizard/index.ts (lines 68, 99, 153), so no dead import was left behind.
No other call sites, docs, or wizard tests reference the old /tskl onboard / Next: wording or the removed commandsInstalled parameter — grepped across packages/cli/src and packages/cli/test.
The spec delta is a full restatement of the requirement (not a partial patch), consistent with the "MODIFIED Requirements replace, not patch" convention in this repo's CLAUDE.md, and both new scenarios read correctly against the new behavior.
New trailer string matches all updated test regexes (^In your AI tool, .*Taskless skill, ask to onboard with Taskless) and doesn't match the negative assertions (/tskl onboard, @taskless/cli@latest onboard).
No new findings. Nothing from a prior review to carry forward, since there wasn't one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful install,
taskless init(and the wizard) printed a trailer that branched on whether the/tsklcommand was installed, and in both forms told the user to run/tskl onboardand/or a pinnednpx @taskless/cli-nightly@… onboardfrom the terminal. That is more than the user needs and leaks a version-pinned command into the first thing they read.The trailer is now a single line for every install plan:
getOnboardTrailer()takes no arguments;initand the wizard stop computingcommandsInstalledfor it (theinit --jsonfield is unchanged).cli-initspec: the trailer requirement and its scenarios now describe the single skill-only line./tskl onboardnor a CLIonboardcommand.