Skip to content

fix(init): point the install trailer at the Taskless skill only - #501

Merged
theCodeDrift merged 1 commit into
mainfrom
fix/install-trailer-skill-only
Oct 14, 2026
Merged

theCodeDrift merged 1 commit into
mainfrom
fix/install-trailer-skill-only

Conversation

@theCodeDrift

Copy link
Copy Markdown
Member

After a successful install, taskless init (and the wizard) printed a trailer that branched on whether the /tskl command was installed, and in both forms told the user to run /tskl onboard and/or a pinned npx @taskless/cli-nightly@… onboard from the terminal. That is more than the user needs and leaks a version-pinned command into the first thing they read.

The trailer is now a single line for every install plan:

In your AI tool, you can use the Taskless skill now - just ask to onboard with Taskless to set up starter rules for your codebase and get a report of what Taskless can catch.

  • getOnboardTrailer() takes no arguments; init and the wizard stop computing commandsInstalled for it (the init --json field is unchanged).
  • cli-init spec: the trailer requirement and its scenarios now describe the single skill-only line.
  • Tests assert the new line, and that it mentions neither /tskl onboard nor a CLI onboard command.
  • Patch changeset added.

@theCodeDrift

Copy link
Copy Markdown
Member Author

@claude /review

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @theCodeDrift's task in 1m 3s —— View job


Review: fix(init): point the install trailer at the Taskless skill only

Review mode: incremental — read 0 prior review thread(s) before reviewing. .prior-review.json contains no prior inline threads, review summaries, or top-level comments beyond the trigger itself, so this is the first review of this PR.

Summary: Clean, well-scoped change. getOnboardTrailer() drops its commandsInstalled argument and returns a single fixed string; both call sites (init.ts, wizard/index.ts) are updated; the cli-init spec delta correctly restates the full requirement text (not just the diff) along with both scenarios; tests assert the new wording and the absence of /tskl onboard and the pinned onboard command; a patch changeset is included.

Checked for issues that often accompany this kind of change:

  • commandsInstalled is still computed and exposed on the init --json envelope (init.ts:114,389,476) — correctly left alone per the PR description, only the trailer-building usage was removed.
  • getCliPrefix import is still used elsewhere in both onboard.ts (line 93) and wizard/index.ts (lines 68, 99, 153), so no dead import was left behind.
  • No other call sites, docs, or wizard tests reference the old /tskl onboard / Next: wording or the removed commandsInstalled parameter — grepped across packages/cli/src and packages/cli/test.
  • The spec delta is a full restatement of the requirement (not a partial patch), consistent with the "MODIFIED Requirements replace, not patch" convention in this repo's CLAUDE.md, and both new scenarios read correctly against the new behavior.
  • New trailer string matches all updated test regexes (^In your AI tool, .*Taskless skill, ask to onboard with Taskless) and doesn't match the negative assertions (/tskl onboard, @taskless/cli@latest onboard).

No new findings. Nothing from a prior review to carry forward, since there wasn't one.

@theCodeDrift
theCodeDrift merged commit 60763fb into main Oct 14, 2026
8 checks passed
@theCodeDrift
theCodeDrift deleted the fix/install-trailer-skill-only branch October 14, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant