Repository navigation
Fix missing tab icons for short file names - #339489
Closed
Marc Mueller (cdce8p) wants to merge 2 commits into
Closed
Marc Mueller (cdce8p) wants to merge 2 commits into
Marc Mueller (cdce8p) wants to merge 2 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The group-wide guard also disables necessary icon collapsing for shrink-sized sticky tabs.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Restores icons for short filenames in Modern UI connected editor tabs, addressing #338171.
Changes:
- Skips icon collapsing when the group uses fit sizing.
- Adds checks for icon and filename preservation across layout widths.
| File | Description |
|---|---|
| src/vs/workbench/test/browser/parts/editor/multiEditorTabsControl.test.ts | Adds connected fit-tab layout coverage. |
| src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts | Guards icon collapsing by group tab sizing. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+386
to
+387
| override getName(): string { return `file${i}.txt`; } | ||
| }(URI.file(`/path/file${i}.txt`), 'testEditorInput')); |
Contributor
Author
There was a problem hiding this comment.
Not necessary. The test still checks that connected-tab-narrow isn't added.
Contributor
Author
|
This issue seems to be resolved on main. Likely with #340635. Closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the ModernUI enabled and
"workbench.experimental.modernUIEditorTabStyle": "connected"(the default), the icon is missing for short file names, even with"workbench.editor.tabSizing": "fit"(the default). This PR restores the "old" behavior and only shrinks / removes the icon iftabSizingis set tofixedorshrink.Fixes: #338171
Before
After
The overflow will move to the horizontal scroll bar