You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
editor: refine Connected tab geometry and visual states - #340635
Fix Connected tab height, spacing, border, and overflow problems while preserving the selected tab's connection to the editor.
Changes
Align Connected tab content heights with Pill in default and compact density, and make wrapped and separate pinned-row gutters consistent.
Fix shoulder gaps, clipped corners, and doubled borders, including customized backgrounds and high-contrast themes. Keep modified indicators and multi-selection visible without closing the selected tab's bottom join.
Prevent Close-button hover backgrounds from spilling outside the tab. In Connected and Pill, hide clean inactive Close buttons until hover or keyboard focus, regardless of action-space reservation.
Restore ordinary end-ellipsis filenames and keep icons on short fit tabs. Refresh fit widths when labels, decorations, or reservation settings change.
Prevent overlapping wrapped editor actions in the Agents Window and reveal the terminal detail tab's Close button and shoulder before Add Tab/fullscreen controls.
Add regression coverage for closing the final chat while scrolled fully right: scrolling clamps, the replacement terminal shoulder appears, and stale clipping clears.
Legacy styling and Pill geometry are unchanged.
Testing
Enable Modern UI and select Connected. Compare default/compact density and tab heights, with wrapping and separate pinned rows on and off. Switch the selected tab between rows; check stable content heights, even gutters, and clean shoulder joins.
Repeat in regular and high-contrast themes with modified tabs, multi-selection, hover, and keyboard focus. Customize tab backgrounds and borders; check the selected outline, modified indicator, and Close-button background.
In Connected and Pill, toggle action-space reservation and Close visibility. Check clean inactive buttons at rest and on hover/focus, hidden disabled Close actions, and retained dirty/pin indicators. Test short and long filenames with fit and shrink sizing; close/reorder tabs and change label options.
In the Agents editor/detail strip, enable wrapping and check Add Tab/fullscreen controls do not overlap. Disable wrapping, overflow the strip, and reveal the final tab at fractional zoom; its Close button and shoulder should be fully visible.
In the Agents main chat strip, scroll fully right and close the final chat. Check the intended chat closes, scrolling clamps, and the new terminal shoulder is visible without a stale overflow mask.
Affected Electron/WebKit tab suites and the existing Playwright tab tests pass, as do client compilation, type-checking, and changed-file hygiene. Manually checked in Code OSS across regular and high-contrast themes, including the Agents terminal tab reveal. See Screenshots & Tests for before/after comparisons.
Align connected content heights, gutters, action targets and theme states while retaining independent convex corners and concave document joins. Preserve fit widths across transient action and editor changes, and reveal terminal tabs before sticky Add Tab controls.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exercise the real decoration provider and resource label event path when an unreserved tab badge is added and removed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Carry explicit and modified top paint independently through overflow caps, include terminal rounding clearance in reveal, and update existing cross-browser fixture assertions to the new paint owners. Repair repository fixture formatting and Agents layout expectations discovered by CI.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This sentence contradicts both this PR and the later action-space sections: Pill now receives the Close-visibility and fit-width reservation changes in tabs.css/multiEditorTabsControl.ts. Qualify the statement as geometry-only so the README does not claim Pill behavior is wholly unchanged.
Qualify the geometry claim so it does not contradict the shared action-space and Close-visibility fixes described below.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exclude bottom-row Connected active multi-selections from this fill border. connectedEditorTabs.css:315-317 already moves their selection color onto the outer cap, but this rule also adds a bottom border to .tab-fill, closing the active tab's connection to the document in regular themes. High-contrast explicitly clears that fill border, and upper-row Connected tabs have their own border rule.
Restrict the shared closed fill outline to Pill active multi-selections; Connected caps and upper pills use their existing dedicated painters. Cover the open document join in regular themes at both tab heights and wrapping states.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The new :not(.active) exclusion leaves a clean active tab with tabActionCloseVisibility: false visibly showing the disabled Close icon: the base active-tab rule gives it opacity, while .close-action-off only disables pointer events. Keep active Close buttons visible when enabled, but explicitly hide clean .close-action-off actions so the setting still removes the control.
Pill documentation: corrected in fc51556. The README now distinguishes unchanged Pill geometry from the shared Close-visibility and action-space fixes.
Connected multi-selection: addressed in 2699578 by excluding Connected active fills from the shared multi-selection border rule. Added regular-theme regression coverage for both tab heights and wrapped/single rows; the document join stays open.
Disabled Close visibility: verified not reproducible. The base editor rule sets the clean disabled action container to display: none, independently of the icon opacity. Confirmed in native Code OSS for Pill and Connected, regular and HC themes, with reservation on/off. No additional CSS override is needed.
The earlier clipped-top-paint inline finding is fixed and its thread resolved. Geometry and hover states were manually reviewed in Component Explorer and Code OSS. CI is still running, with no failures currently reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Connected tab height, spacing, border, and overflow problems while preserving the selected tab's connection to the editor.
Changes
fittabs. Refresh fit widths when labels, decorations, or reservation settings change.Legacy styling and Pill geometry are unchanged.
Testing
fitandshrinksizing; close/reorder tabs and change label options.Affected Electron/WebKit tab suites and the existing Playwright tab tests pass, as do client compilation, type-checking, and changed-file hygiene. Manually checked in Code OSS across regular and high-contrast themes, including the Agents terminal tab reveal. See Screenshots & Tests for before/after comparisons.
Fixes #340427
Fixes #339963
Fixes #339962
Fixes #339673
Fixes #338948
Fixes #338446
Fixes #337728
Fixes #337502
Fixes #337476
Fixes #336898
Fixes #326833